<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eugene.Zelenko created this revision.<br>
Eugene.Zelenko added reviewers: alexfh, aaron.ballman.<br>
Eugene.Zelenko added a subscriber: cfe-commits.<br>
Eugene.Zelenko set the repository for this revision to rL LLVM.<br>
<br>
I checked this patch on my own build on RHEL 6. Regressions were OK.<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D16566" rel="noreferrer" target="_blank">http://reviews.llvm.org/D16566</a><br>
<br>
Files:<br>
  unittests/clang-tidy/IncludeInserterTest.cpp<br>
<br>
Index: unittests/clang-tidy/IncludeInserterTest.cpp<br>
===================================================================<br>
--- unittests/clang-tidy/IncludeInserterTest.cpp<br>
+++ unittests/clang-tidy/IncludeInserterTest.cpp<br>
@@ -98,7 +98,7 @@<br>
 public:<br>
   CXXSystemIncludeInserterCheck(StringRef CheckName, ClangTidyContext *Context)<br>
       : IncludeInserterCheckBase(CheckName, Context) {}<br>
-  virtual ~CXXSystemIncludeInserterCheck() {}<br>
+  ~CXXSystemIncludeInserterCheck() override = default;<br></blockquote><div><br></div><div>Perhaps we should just remove this user-declared dtor entirely? The implicitly provided dtor will do all that by default anyway...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   std::vector<StringRef> HeadersToInclude() const override { return {"set"}; }<br>
   bool IsAngledInclude() const override { return true; }<br>
@@ -522,7 +522,7 @@<br>
                                    "insert_includes_test_header.cc"));<br>
 }<br>
<br>
-} // namespace<br>
+} // anonymous namespace<br>
 } // namespace tidy<br>
 } // namespace clang<br>
<br>
<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>