<div dir="ltr">I have some benchmarks, but none of them moved when I added the support that I could see. It wouldn't catch small regressions though.<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 20, 2016 at 3:17 PM Romanova, Katya <<a href="mailto:Katya_Romanova@playstation.sony.com">Katya_Romanova@playstation.sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I see. I was hoping that if you were, I could have used the same benchmark and compare what build time increase caused by using target attributes (might be
much more substantial) and by adding doxygen comments.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eric Christopher [mailto:<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]
<br>
<b>Sent:</b> Wednesday, January 20, 2016 3:09 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD15999%2Bpublic%2B772a9901b981d210@reviews.llvm.org" target="_blank">reviews+D15999+public+772a9901b981d210@reviews.llvm.org</a>; Romanova, Katya; <a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>; <a href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>; Gao, Yunzhong; Sean Silva<br>
<b>Cc:</b> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<b>Subject:</b> Re: [PATCH] D15999: Adding doxygen comments to the LLVM intrinsics (part 2, _wmmintrin_pclmul.h)<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Jan 20, 2016 at 2:32 PM Katya Romanova via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">kromanova added a comment.<br>
<br>
In <a href="http://reviews.llvm.org/D15999#330794" target="_blank">http://reviews.llvm.org/D15999#330794</a>, @silvas wrote:<br>
<br>
> This may sound stupid, but: can you benchmark the time it takes to build some project (that actually uses intrinsics in most translation units, e.g. a game) with the headers w/ and w/o the doxygen comments to check that all the extra comment skipping doesn't
affect compilation time? I.e. run your script to add the comments for "all" the intrinsic headers (similar to what you expect the final state to be after all these patches) and test the build time of a game (and compare with the unmodified headers).<br>
><br>
> Also, can you post a patch that changes "all" the headers to have doxygen comments like you intend, so that others can test and verify?<br>
<br>
<br>
Out of curiosity, do you know if the impact to the build time for Eric's change of starting to use the target attributes instead of conditional inclusion was measured (r239883) on a large scale application. If so, what were the results? I should probably include
Eric.<u></u><u></u></p>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I did not as the feature compatibility was fairly important here. That said, I don't really expect the compile time difference for the comment skipping to matter in any large way and having documentation seems pretty nice. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">-eric<u></u><u></u></p>
</div>
</div>
</div>
</div></div></div></blockquote></div>