<div dir="ltr">No worries, I reviewed at least some of these changes and haven't found the issues, but was later pointed to them by a community member ;)<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 18, 2016 at 11:58 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Jan 18, 2016 at 5:51 PM, Alexander Kornienko via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: alexfh<br>
> Date: Mon Jan 18 16:51:09 2016<br>
> New Revision: 258098<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=258098&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=258098&view=rev</a><br>
> Log:<br>
> [clang-tidy] Fixed wording ("clang-tidy check", not "clang-tidy checker")<br>
<br>
</span>Sorry about that -- community terminology can be hard to keep straight<br>
sometimes. ;-)<br>
<span class="HOEnZb"><font color="#888888"><br>
~Aaron<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Modified:<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst<br>
> clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl03-c.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,5 +5,5 @@<br>
> cert-dcl03-c<br>
> ============<br>
><br>
> -The cert-dcl03-c checker is an alias, please see<br>
> +The cert-dcl03-c check is an alias, please see<br>
> `misc-static-assert <misc-static-assert.html>`_ for more information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl54-cpp.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,6 +5,6 @@<br>
> cert-dcl54-cpp<br>
> ==============<br>
><br>
> -The cert-dcl54-cpp checker is an alias, please see<br>
> +The cert-dcl54-cpp check is an alias, please see<br>
> `misc-new-delete-overloads <misc-new-delete-overloads.html>`_ for more<br>
> information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-dcl59-cpp.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,5 +5,5 @@<br>
> cert-dcl59-cpp<br>
> ==============<br>
><br>
> -The cert-dcl59-cpp checker is an alias, please see<br>
> +The cert-dcl59-cpp check is an alias, please see<br>
> `google-build-namespaces <google-build-namespaces.html>`_ for more information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-err61-cpp.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,6 +5,6 @@<br>
> cert-err61-cpp<br>
> ==============<br>
><br>
> -The cert-err61-cpp checker is an alias, please see<br>
> +The cert-err61-cpp check is an alias, please see<br>
> `misc-throw-by-value-catch-by-reference <misc-throw-by-value-catch-by-reference.html>`_<br>
> for more information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-fio38-c.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,6 +5,6 @@<br>
> cert-fio38-c<br>
> ============<br>
><br>
> -The cert-fio38-c checker is an alias, please see<br>
> +The cert-fio38-c check is an alias, please see<br>
> `misc-non-copyable-objects <misc-non-copyable-objects.html>`_ for more<br>
> information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/cert-oop11-cpp.rst Mon Jan 18 16:51:09 2016<br>
> @@ -5,6 +5,6 @@<br>
> cert-oop11-cpp<br>
> ==============<br>
><br>
> -The cert-oop11-cpp checker is an alias, please see<br>
> +The cert-oop11-cpp check is an alias, please see<br>
> `misc-move-constructor-init <misc-move-constructor-init.html>`_ for more<br>
> information.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/google-build-namespaces.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> google-build-namespaces<br>
> =======================<br>
><br>
> -"cert-dcl59-cpp" redirects here as an alias for this checker.<br>
> +"cert-dcl59-cpp" redirects here as an alias for this check.<br>
><br>
> Finds anonymous namespaces in headers.<br>
><br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-move-constructor-init.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> misc-move-constructor-init<br>
> ==========================<br>
><br>
> -"cert-oop11-cpp" redirects here as an alias for this checker.<br>
> +"cert-oop11-cpp" redirects here as an alias for this check.<br>
><br>
> The check flags user-defined move constructors that have a ctor-initializer<br>
> initializing a member or base class through a copy constructor instead of a<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-new-delete-overloads.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> misc-new-delete-overloads<br>
> =========================<br>
><br>
> -"cert-dcl54-cpp" redirects here as an alias for this checker.<br>
> +"cert-dcl54-cpp" redirects here as an alias for this check.<br>
><br>
> The check flags overloaded operator new() and operator delete() functions that<br>
> do not have a corresponding free store function defined within the same scope.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-non-copyable-objects.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> misc-non-copyable-objects<br>
> =========================<br>
><br>
> -"cert-fio38-c" redirects here as an alias for this checker.<br>
> +"cert-fio38-c" redirects here as an alias for this check.<br>
><br>
> The check flags dereferences and non-pointer declarations of objects that are<br>
> not meant to be passed by value, such as C FILE objects or POSIX<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-static-assert.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> misc-static-assert<br>
> ==================<br>
><br>
> -"cert-dcl03-c" redirects here as an alias for this checker.<br>
> +"cert-dcl03-c" redirects here as an alias for this check.<br>
><br>
> Replaces ``assert()`` with ``static_assert()`` if the condition is evaluatable<br>
> at compile time.<br>
><br>
> Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst?rev=258098&r1=258097&r2=258098&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst?rev=258098&r1=258097&r2=258098&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst (original)<br>
> +++ clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst Mon Jan 18 16:51:09 2016<br>
> @@ -3,7 +3,7 @@<br>
> misc-throw-by-value-catch-by-reference<br>
> ======================================<br>
><br>
> -"cert-err61-cpp" redirects here as an alias for this checker.<br>
> +"cert-err61-cpp" redirects here as an alias for this check.<br>
><br>
> Finds violations of the rule "Throw by value, catch by reference" presented for example in "C++ Coding Standards" by H. Sutter and A. Alexandrescu. This check also has the option to find violations of the rule "Throw anonymous temporaries" (<a href="https://www.securecoding.cert.org/confluence/display/cplusplus/ERR09-CPP.+Throw+anonymous+temporaries" rel="noreferrer" target="_blank">https://www.securecoding.cert.org/confluence/display/cplusplus/ERR09-CPP.+Throw+anonymous+temporaries</a>). The option is named "CheckThrowTemporaries" and it's on by default.<br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>