<div dir="ltr">Forward to the 'new' mailing list.<br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">David Blaikie</b> <span dir="ltr"><<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>></span><br>Date: Fri, Jan 15, 2016 at 6:08 PM<br>Subject: Re: [PATCH] Proposed fix for PR23076 (conditional branch debug line info)<br>To: <a href="mailto:reviews%2BD8822%2Bpublic%2B818b95c17195c725@reviews.llvm.org">reviews+D8822+public+818b95c17195c725@reviews.llvm.org</a>, "Robinson, Paul" <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>>, Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>><br>Cc: "Pieb, Wolfgang" <<a href="mailto:wolfgang_pieb@playstation.sony.com">wolfgang_pieb@playstation.sony.com</a>>, llvm cfe <<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>><br><br><br><div dir="ltr">Apologies for the massively delayed review. I think this is probably good, but here are some test cases to discuss (& I've cc'd Paul Robinson and Adrian Prantl, both who work on debug info in LLVM as well, to get their thoughts)<br><br>Given this code:<br><pre style="color:rgb(0,0,0)"> 1. int main() {
2. if (
3. tr()
4. &&
5. tr()
6. )
7. func();
8.
9. if (
10. fa()
11. &&
12. tr()
13. )
14. func();
15. }</pre>G++-4.8:<br><div>3, 4, 5, 4, 2, 7<br>10, 11, 9, 15<br><br>Clang before the change:<br>3, 4, 5, 3, 7<br>10, 11, 15<br><br></div><div>Clang after the change:<br>3, 5, 7<br>10, 15<br><br>The lack of stepping between the evaluation of the LHS and the RHS to the && expression seems like a loss, but not a great one. How's everyone else feel about it? (I imagine we can, with some work, preserve that step while avoiding the weird backwards step to the start of the expression before continuing)</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 1, 2015 at 1:00 PM, Wolfgang Pieb <span dir="ltr"><<a href="mailto:wolfgang_pieb@playstation.sony.com" target="_blank">wolfgang_pieb@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David, did you have a chance to look at the new patch? There are a couple of new tests piggy-backing on the existing test case.<br>
<div><div><br>
<br>
<a href="http://reviews.llvm.org/D8822" rel="noreferrer" target="_blank">http://reviews.llvm.org/D8822</a><br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>
</div></div></div><br></div>