<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 15, 2016 at 2:29 PM, Joerg Sonnenberger via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: joerg<br>
Date: Fri Jan 15 16:29:34 2016<br>
New Revision: 257947<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=257947&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=257947&view=rev</a><br>
Log:<br>
Avoid self-assignment of SmallString, trigger UB behavior down the road.<br></blockquote><div><br></div><div>Shouldn't we be fixing that in SmallString? (self /move/ assignment arguably can be UB, but self copy assign probably shouldn't be)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/tools/driver/driver.cpp<br>
<br>
Modified: cfe/trunk/tools/driver/driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=257947&r1=257946&r2=257947&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=257947&r1=257946&r2=257947&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/driver/driver.cpp (original)<br>
+++ cfe/trunk/tools/driver/driver.cpp Fri Jan 15 16:29:34 2016<br>
@@ -290,9 +290,9 @@ static void SetInstallDir(SmallVectorImp<br>
   if (CanonicalPrefixes)<br>
     llvm::sys::fs::make_absolute(InstalledPath);<br>
<br>
-  InstalledPath = llvm::sys::path::parent_path(InstalledPath);<br>
-  if (llvm::sys::fs::exists(InstalledPath.c_str()))<br>
-    TheDriver.setInstalledDir(InstalledPath);<br>
+  StringRef InstalledPathParent(llvm::sys::path::parent_path(InstalledPath));<br>
+  if (llvm::sys::fs::exists(InstalledPathParent))<br>
+    TheDriver.setInstalledDir(InstalledPathParent);<br>
 }<br>
<br>
 static int ExecuteCC1Tool(ArrayRef<const char *> argv, StringRef Tool) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>