<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi Samuel,<o:p></o:p></p>
<p class="MsoNormal">I noticed that the two tests you added in the below commit have a minor issue.<o:p></o:p></p>
<p class="MsoNormal">“<span style="color:black">target_codegen_registration_naming.cpp” is failing on my local machine (Win32).<o:p></o:p></span></p>
<p class="MsoNormal">“<span style="color:black">target_codegen_registration.cpp” is not failing, but it contain “CHECK…” lines with wrong syntax that make FileCheck ignore them.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black">Please, see the attach patch I suggest for fixing these test.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:black">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">Amjad</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<pre><span style="color:black">Author: sfantao<o:p></o:p></span></pre>
<pre><span style="color:black">Date: Wed Jan 6 07:42:12 2016<o:p></o:p></span></pre>
<pre><span style="color:black">New Revision: 256933<o:p></o:p></span></pre>
<pre><span style="color:black"><o:p> </o:p></span></pre>
<pre><span style="color:black">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=256933&view=rev">http://llvm.org/viewvc/llvm-project?rev=256933&view=rev</a><o:p></o:p></span></pre>
<pre><span style="color:black">Log:<o:p></o:p></span></pre>
<pre><span style="color:black">[OpenMP] Reapply rL256842: [OpenMP] Offloading descriptor registration and device codegen.<o:p></o:p></span></pre>
<pre><span style="color:black"><o:p> </o:p></span></pre>
<pre><span style="color:black">This patch attempts to fix the regressions identified when the patch was committed initially. <o:p></o:p></span></pre>
<pre><span style="color:black"><o:p> </o:p></span></pre>
<pre><span style="color:black">Thanks to Michael Liao for identifying the fix in the offloading metadata generation <o:p></o:p></span></pre>
<pre><span style="color:black">related with side effects in evaluation of function arguments. <o:p></o:p></span></pre>
<pre><span style="color:black"> <o:p></o:p></span></pre>
<pre><span style="color:black"><o:p> </o:p></span></pre>
<pre><span style="color:black">Added:<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_codegen_registration.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp<o:p></o:p></span></pre>
<pre><span style="color:black">Modified:<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/include/clang/Basic/LangOptions.def<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/include/clang/Basic/LangOptions.h<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/include/clang/Driver/CC1Options.td<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/include/clang/Driver/Options.td<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/CodeGen/CodeGenModule.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/Serialization/ASTReader.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/lib/Serialization/ASTWriter.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_codegen.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_codegen_global_capture.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_map_codegen.cpp<o:p></o:p></span></pre>
<pre><span style="color:black"> cfe/trunk/test/OpenMP/target_messages.cpp<o:p></o:p></span></pre>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>