<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1235236632;
mso-list-template-ids:-2080581152;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:\F0B7;
mso-level-tab-stop:.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:\F0A7;
mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Samuel<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">The issue is not related to capture feature but the order of evaluation which is not specified for arguments in a function call in C/C++. With the side effect
in each argument evaluation, it causes the trouble.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">- Michael<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Samuel F Antao [mailto:sfantao@us.ibm.com]
<br>
<b>Sent:</b> Tuesday, January 5, 2016 4:25 PM<br>
<b>To:</b> Liao, Michael <michael.liao@intel.com><br>
<b>Cc:</b> cfe-commits <cfe-commits@lists.llvm.org>; Artem Belevich <tra@google.com><br>
<b>Subject:</b> RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hi Michael,<br>
<br>
Thanks for the patch! I am not sure I understand why the behavior is unspecified if Idx is captured by reference, but that is good to know that it fixes the problem. I reverted the patch in the meantime given that I am still trying to replicate a problem I
get from the ARM bots, but I will incorporate your fix when I am ready to reapply the patch.<br>
<br>
Thanks again!<br>
Samuel<br>
<br>
<img width="16" height="16" id="_x0000_i1025" src="cid:image001.gif@01D147DA.40B60B90" alt="Inactive hide details for "Liao, Michael" ---01/05/2016 05:17:13 PM---Hi Samual The change in CL#256842 has undefined behavior "><span style="color:#424282">"Liao, Michael"
---01/05/2016 05:17:13 PM---Hi Samual The change in CL#256842 has undefined behavior according to C++. Attached patch will avoid</span><br>
<br>
<span style="font-size:10.0pt;color:#5F5F5F">From: </span><span style="font-size:10.0pt">"Liao, Michael" <<a href="mailto:michael.liao@intel.com">michael.liao@intel.com</a>></span><br>
<span style="font-size:10.0pt;color:#5F5F5F">To: </span><span style="font-size:10.0pt">Samuel F Antao/Watson/IBM@IBMUS, Artem Belevich <<a href="mailto:tra@google.com">tra@google.com</a>></span><br>
<span style="font-size:10.0pt;color:#5F5F5F">Cc: </span><span style="font-size:10.0pt">cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>></span><br>
<span style="font-size:10.0pt;color:#5F5F5F">Date: </span><span style="font-size:10.0pt">01/05/2016 05:17 PM</span><br>
<span style="font-size:10.0pt;color:#5F5F5F">Subject: </span><span style="font-size:10.0pt">RE: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.</span><o:p></o:p></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade="" style="color:#8091A5" align="left">
</div>
<p class="MsoNormal"><br>
<br>
<br>
<span style="font-family:"Calibri",sans-serif;color:#1F497D">Hi Samual</span><br>
<br>
<span style="font-family:"Calibri",sans-serif;color:#1F497D">The change in CL#256842 has undefined behavior according to C++. Attached patch will avoid side-effect code during argument evaluation of a function call. That solves the problem for me on Linux with
GCC 4.9.</span><br>
<br>
<span style="font-family:"Calibri",sans-serif;color:#1F497D">Thanks</span><br>
<span style="font-family:"Calibri",sans-serif;color:#1F497D">- Michael</span><br>
<br>
<b><span style="font-family:"Calibri",sans-serif">From:</span></b><span style="font-family:"Calibri",sans-serif"> cfe-commits [<a href="mailto:cfe-commits-bounces@lists.llvm.org">mailto:cfe-commits-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Samuel F Antao via cfe-commits<b><br>
Sent:</b> Tuesday, January 5, 2016 10:57 AM<b><br>
To:</b> Artem Belevich <<a href="mailto:tra@google.com">tra@google.com</a>><b><br>
Cc:</b> cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><b><br>
Subject:</b> Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.</span><o:p></o:p></p>
<p><span style="font-size:13.5pt">Hi Art,<br>
<br>
That only fixed one of the problems. The other one I am having some trouble to replicate. I am trying a few things and hopefully will get a fix soon.<br>
<br>
Sorry for the trouble,<br>
Samuel<br>
<br>
</span><img border="0" width="16" height="16" id="_x0000_i1027" src="cid:image001.gif@01D147DA.40B60B90" alt="Inactive hide details for Artem Belevich ---01/05/2016 01:54:02 PM---Samuel, The tests are still failing:"><span style="font-size:13.5pt;color:#424282">Artem
Belevich ---01/05/2016 01:54:02 PM---Samuel, The tests are still failing:</span><span style="font-size:13.5pt"><br>
</span><span style="color:#5F5F5F"><br>
From: </span>Artem Belevich <<a href="mailto:tra@google.com">tra@google.com</a>><span style="color:#5F5F5F"><br>
To: </span>Samuel F Antao/Watson/IBM@IBMUS<span style="color:#5F5F5F"><br>
Cc: </span>cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><span style="color:#5F5F5F"><br>
Date: </span>01/05/2016 01:54 PM<span style="color:#5F5F5F"><br>
Subject: </span>Re: r256854 - [OpenMP] Allow file ID to be signed in the offloading metadata.<o:p></o:p></p>
<div class="MsoNormal">
<hr size="2" width="100%" noshade="" style="color:#A0A0A0" align="left">
</div>
<p class="MsoNormal"><br>
<span style="font-size:13.5pt"><br>
<br>
</span><span style="font-size:18.0pt"><br>
Samuel,</span><span style="font-size:13.5pt"><br>
</span><span style="font-size:18.0pt"><br>
The tests are still failing:</span><u><span style="font-size:13.5pt;color:blue"><br>
</span></u><a href="http://lab.llvm.org:8011/builders/clang-bpf-build/builds/5759"><span style="font-size:18.0pt">http://lab.llvm.org:8011/builders/clang-bpf-build/builds/5759</span></a><span style="font-size:13.5pt"><br>
<br>
<br>
</span><span style="font-size:18.0pt"><br>
On Tue, Jan 5, 2016 at 10:02 AM, Samuel Antao via cfe-commits <</span><a href="mailto:cfe-commits@lists.llvm.org" target="_blank"><span style="font-size:18.0pt">cfe-commits@lists.llvm.org</span></a><span style="font-size:18.0pt">> wrote:</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:1.0in"><span style="font-size:18.0pt">Author: sfantao<br>
Date: Tue Jan 5 12:02:24 2016<br>
New Revision: 256854<br>
<br>
URL: </span><a href="http://llvm.org/viewvc/llvm-project?rev=256854&view=rev" target="_blank"><span style="font-size:18.0pt">http://llvm.org/viewvc/llvm-project?rev=256854&view=rev</span></a><span style="font-size:18.0pt"><br>
Log:<br>
[OpenMP] Allow file ID to be signed in the offloading metadata.<br>
<br>
This fixes a regression introduced by rL256842.<br>
<br>
<br>
Modified:<br>
cfe/trunk/test/OpenMP/target_codegen_registration.cpp<br>
cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp<br>
<br>
Modified: cfe/trunk/test/OpenMP/target_codegen_registration.cpp<br>
URL: </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/OpenMP/target_codegen_registration.cpp?rev=256854&r1=256853&r2=256854&view=diff" target="_blank"><span style="font-size:18.0pt">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/OpenMP/target_codegen_registration.cpp?rev=256854&r1=256853&r2=256854&view=diff</span></a><span style="font-size:18.0pt"><br>
==============================================================================<br>
--- cfe/trunk/test/OpenMP/target_codegen_registration.cpp (original)<br>
+++ cfe/trunk/test/OpenMP/target_codegen_registration.cpp Tue Jan 5 12:02:24 2016<br>
@@ -407,7 +407,7 @@ int bar(int a){<br>
<br>
// Check metadata is properly generated:<br>
// CHECK: !</span><a href="http://omp_offload.info/" target="_blank"><span style="font-size:18.0pt">omp_offload.info</span></a><span style="font-size:18.0pt"> = !{!{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}},
!{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}}<br>
-// CHECK-DAG = !{i32 0, i32 [[DEVID:[0-9]+]], i32 [[FILEID:[0-9]+]], !"_ZN2SB3fooEv", i32 160, i32 13, i32 {{[0-9]}}+}<br>
+// CHECK-DAG = !{i32 0, i32 [[DEVID:[0-9]+]], i32 [[FILEID:-?[0-9]+]], !"_ZN2SB3fooEv", i32 160, i32 13, i32 {{[0-9]}}+}<br>
// CHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SDD2Ev", i32 210, i32 13, i32 {{[0-9]}}+}<br>
// CHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SEC2Ev", i32 226, i32 13, i32 {{[0-9]}}+}<br>
// CHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SED2Ev", i32 232, i32 13, i32 {{[0-9]}}+}<br>
@@ -421,7 +421,7 @@ int bar(int a){<br>
// CHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SCC2Ev", i32 185, i32 13, i32 {{[0-9]}}+}<br>
<br>
// TCHECK: !</span><a href="http://omp_offload.info/" target="_blank"><span style="font-size:18.0pt">omp_offload.info</span></a><span style="font-size:18.0pt"> = !{!{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}},
!{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}, !{{[0-9]+}}}<br>
-// TCHECK-DAG = !{i32 0, i32 [[DEVID:[0-9]+]], i32 [[FILEID:[0-9]+]], !"_ZN2SB3fooEv", i32 160, i32 13, i32 {{[0-9]}}+}<br>
+// TCHECK-DAG = !{i32 0, i32 [[DEVID:[0-9]+]], i32 [[FILEID:-?[0-9]+]], !"_ZN2SB3fooEv", i32 160, i32 13, i32 {{[0-9]}}+}<br>
// TCHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SDD2Ev", i32 210, i32 13, i32 {{[0-9]}}+}<br>
// TCHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SEC2Ev", i32 226, i32 13, i32 {{[0-9]}}+}<br>
// TCHECK-DAG = !{i32 0, i32 [[DEVID]], i32 [[FILEID]] !"_ZN2SED2Ev", i32 232, i32 13, i32 {{[0-9]}}+}<br>
<br>
Modified: cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp<br>
URL: </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp?rev=256854&r1=256853&r2=256854&view=diff" target="_blank"><span style="font-size:18.0pt">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp?rev=256854&r1=256853&r2=256854&view=diff</span></a><span style="font-size:18.0pt"><br>
==============================================================================<br>
--- cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp (original)<br>
+++ cfe/trunk/test/OpenMP/target_codegen_registration_naming.cpp Tue Jan 5 12:02:24 2016<br>
@@ -57,10 +57,10 @@ int nested(int a){<br>
<br>
// Check metadata is properly generated:<br>
// CHECK: !</span><a href="http://omp_offload.info/" target="_blank"><span style="font-size:18.0pt">omp_offload.info</span></a><span style="font-size:18.0pt"> = !{!{{[0-9]+}}, !{{[0-9]+}}}<br>
-// CHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{[0-9]+}}, !"[[NNAME]]", i32 [[T1L]], i32 [[T1C]], i32 {{[0-9]+}}}<br>
-// CHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{[0-9]+}}, !"[[NNAME]]", i32 [[T2L]], i32 [[T2C]], i32 {{[0-9]+}}}<br>
+// CHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{-?[0-9]+}}, !"[[NNAME]]", i32 [[T1L]], i32 [[T1C]], i32 {{[0-9]+}}}<br>
+// CHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{-?[0-9]+}}, !"[[NNAME]]", i32 [[T2L]], i32 [[T2C]], i32 {{[0-9]+}}}<br>
<br>
// TCHECK: !</span><a href="http://omp_offload.info/" target="_blank"><span style="font-size:18.0pt">omp_offload.info</span></a><span style="font-size:18.0pt"> = !{!{{[0-9]+}}, !{{[0-9]+}}}<br>
-// TCHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{[0-9]+}}, !"[[NNAME]]", i32 [[T1L]], i32 [[T1C]], i32 {{[0-9]+}}}<br>
-// TCHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{[0-9]+}}, !"[[NNAME]]", i32 [[T2L]], i32 [[T2C]], i32 {{[0-9]+}}}<br>
+// TCHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{-?[0-9]+}}, !"[[NNAME]]", i32 [[T1L]], i32 [[T1C]], i32 {{[0-9]+}}}<br>
+// TCHECK-DAG: = !{i32 0, i32 {{[0-9]+}}, i32 {{-?[0-9]+}}, !"[[NNAME]]", i32 [[T2L]], i32 [[T2C]], i32 {{[0-9]+}}}<br>
#endif<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list</span><u><span style="font-size:13.5pt;color:blue"><br>
</span></u><a href="mailto:cfe-commits@lists.llvm.org"><span style="font-size:18.0pt">cfe-commits@lists.llvm.org</span></a><u><span style="font-size:13.5pt;color:blue"><br>
</span></u><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank"><span style="font-size:18.0pt">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</span></a><o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:13.5pt"><br>
<br>
</span><span style="font-size:18.0pt"><br>
-- <br>
--Artem Belevich[attachment "0001-Avoid-side-effect-in-function-call.patch" deleted by Samuel F Antao/Watson/IBM]
</span><o:p></o:p></p>
</div>
</body>
</html>