<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 11, 2015 at 6:12 PM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Easwaran Raman <<a href="mailto:eraman@google.com">eraman@google.com</a>> writes:<br>
> eraman added a comment.<br>
><br>
> I have reverted the commit in r255416 because the test failed in many<br>
> architectures.<br>
<br>
</span>You also committed without waiting for further review, despite that<br>
David said "LGTM but please wait for other reviewers". Please don't do<br>
that in the future.<br></blockquote><div><br></div><div>Sorry about that. I waited for a few days, but the right thing to do would have been to explicitly ping the reviewers. Will do so in the future.</div><div><br></div><div>- Easwaran</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5"><br>
> In many cases the linker is not able to find<br>
> libclang_rt.profile-$ARCH.a file. There are also other errors. Here is<br>
> one:<br>
><br>
> 0. Program arguments:<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/clang<br>
> -cc1 -triple hexagon-unknown--elf -emit-obj -disable-free<br>
> -main-file-name pgo-max-function-count.c -mrelocation-model static<br>
> -mthread-model posix -mdisable-fp-elim -fmath-errno -masm-verbose<br>
> -mconstructor-aliases -target-cpu hexagonv4 -mqdsp6-compat<br>
> -Wreturn-type -fshort-enums -mllvm -machine-sink-split=0<br>
> -target-linker-version 2.25 -dwarf-column-info<br>
> -fprofile-instr-generate -resource-dir<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../lib/clang/3.8.0<br>
> -internal-externc-isystem<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/lib/gcc/hexagon/0.0.0/include<br>
> -internal-externc-isystem<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/lib/gcc/hexagon/0.0.0/include-fixed<br>
> -internal-externc-isystem<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../../gnu/hexagon/include<br>
> -O2 -fdebug-compilation-dir<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/tools/clang/test/CodeGen<br>
> -ferror-limit 19 -fmessage-length 0 -fshort-enums -fno-signed-char<br>
> -fno-use-cxa-atexit -fobjc-runtime=gcc -fdiagnostics-show-option<br>
> -vectorize-loops -vectorize-slp -o<br>
> /tmp/pgo-max-function-count-816195.o -x c<br>
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.src/tools/clang/test/CodeGen/pgo-max-function-count.c<br>
><br>
> <snip><br>
><br>
> Target: hexagon-unknown--elf<br>
><br>
> Seems like the command line is messed up (I assume there should be a<br>
> space between hexagon-unknown and --elf).<br>
><br>
> Any suggestions on how to fix this test case? AFAICT, there are no PGO<br>
> related tests in clang and I based this on PGO tests in compiler-rt/<br>
<br>
</div></div>I'll comment on the patch, but you can't write tests in clang that<br>
attempt to compile and run the compiled binary.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Repository:<br>
>   rL LLVM<br>
><br>
> <a href="http://reviews.llvm.org/D15163" rel="noreferrer" target="_blank">http://reviews.llvm.org/D15163</a><br>
</div></div></blockquote></div><br></div></div>