<div dir="ltr">Oh, this type has a user-defined dtor, so it's deprecated to use the implicit copy ctor/assignment operator anyway - and I have the -Wdeprecated flag on in my build (& keep the LLVM build clean of any warnings it shows).<br><br>At some point (would love help) we should just turn that on for everyone, then we wouldn't have to worry about types like this -Wdeprecated -Werror would catch them. I think last time I tried to turn it on there were some things in library headers, perhaps (maybe in cxxabi?) that needed cleaning up that I didn't have/build/see locally...<br><br>- Dave</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 2, 2015 at 9:57 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Dec 2, 2015 at 7:05 AM, Aaron Ballman via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aaronballman<br>
Date: Wed Dec  2 09:05:47 2015<br>
New Revision: 254515<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254515&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254515&view=rev</a><br>
Log:<br>
Amending r254423 by deleting the copy constructor and adding a move constructor instead; NFC as neither of these constructors are currently called, but this is a safer design.<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/Sema/AttributeList.h<br>
<br>
Modified: cfe/trunk/include/clang/Sema/AttributeList.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/AttributeList.h?rev=254515&r1=254514&r2=254515&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/AttributeList.h?rev=254515&r1=254514&r2=254515&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Sema/AttributeList.h (original)<br>
+++ cfe/trunk/include/clang/Sema/AttributeList.h Wed Dec  2 09:05:47 2015<br>
@@ -557,6 +557,13 @@ public:<br>
   /// Create a new pool for a factory.<br>
   AttributePool(AttributeFactory &factory) : Factory(factory), Head(nullptr) {}<br>
<br>
+  AttributePool(AttributePool &) = delete;<br></blockquote><div><br></div></span><div>FWIW, once you add the move ctor, the copy ctor is implicitly deleted anyway</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
+  /// Move the given pool's allocations to this pool.<br>
+  AttributePool(AttributePool &&pool) : Factory(pool.Factory), Head(pool.Head) {<br>
+    pool.Head = nullptr;<br>
+  }<br>
+<br>
   AttributeFactory &getFactory() const { return Factory; }<br>
<br>
   void clear() {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div>