<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>This patch proposal is now on Phabricator: <a target="_blank" defang_rel="noreferrer" href="http://reviews.llvm.org/D15090">http://reviews.llvm.org/D15090</a> - let's continue this discussion there.<br></div>
<div> </div>
<blockquote><pre class="defanged1-u-article">At a glance, I wonder if it's worth it to provide a CheckerContext
inside this callback and then handle transitions properly (which would
allow the checker to split the program state at the very beginning of
the function). I cannot instantly think of a use-case (hmm, maybe
somebody would like to eagerly discriminate between a NULL and non-NULL
pointer argument of the function), but at the same time I don't see any
obvious problems with adding it, especially because it'd be hard to
change the API when the use-case appears.<br></pre></blockquote><div> </div>
<div>Artem: thanks for your comment! I've added it to the Phabricator summary, along with my reaction to it. I think your proposal is good, I've started working on implementing it, but I also want to hear what others (Anna, Jordan) think.<br></div>
<div> </div>
<div id="sig30782065"><div class="signature">---<br></div>
<div class="signature">Best regards,<br></div>
<div class="signature"> </div>
<div class="signature">Gábor 'ShdNx' Kozár<br></div>
<div class="signature"><a href="http://gaborkozar.me">http://gaborkozar.me</a><br></div>
<div class="signature"> </div>
</div>
<div> </div>
<div> </div>
<div>On Mon, Nov 30, 2015, at 16:38, Artem Dergachev via cfe-commits wrote:<br></div>
<blockquote type="cite"><div>Hmm. I once thought about creating a 'checkBeginAnalysis()' callback to<br></div>
<div>match 'checkEndAnalysis()'; this one's more powerful, and matches<br></div>
<div>'checkEndFunction()' in a similar manner.<br></div>
<div> </div>
<div>At a glance, I wonder if it's worth it to provide a CheckerContext<br></div>
<div>inside this callback and then handle transitions properly (which would<br></div>
<div>allow the checker to split the program state at the very beginning of<br></div>
<div>the function). I cannot instantly think of a use-case (hmm, maybe<br></div>
<div>somebody would like to eagerly discriminate between a NULL and non-NULL<br></div>
<div>pointer argument of the function), but at the same time I don't see any<br></div>
<div>obvious problems with adding it, especially because it'd be hard to<br></div>
<div>change the API when the use-case appears.<br></div>
<div><u>_______________________________________________</u><br></div>
<div>cfe-commits mailing list<br></div>
<div><a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br></div>
<div><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br></div>
</blockquote><div> </div>
</body>
</html>