<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Dec 1, 2015 at 3:42 PM, Duncan P. N. Exon Smith via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015-Dec-01, at 09:15, Aaron Ballman via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: aaronballman<br>
> Date: Tue Dec  1 11:15:13 2015<br>
> New Revision: 254423<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254423&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254423&view=rev</a><br>
> Log:<br>
> It appears that this horrible mutating copy constructor is unused. Kill it with fire.<br>
><br>
> Modified:<br>
>    cfe/trunk/include/clang/Sema/AttributeList.h<br>
><br>
> Modified: cfe/trunk/include/clang/Sema/AttributeList.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/AttributeList.h?rev=254423&r1=254422&r2=254423&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/AttributeList.h?rev=254423&r1=254422&r2=254423&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Sema/AttributeList.h (original)<br>
> +++ cfe/trunk/include/clang/Sema/AttributeList.h Tue Dec  1 11:15:13 2015<br>
> @@ -557,11 +557,6 @@ public:<br>
>   /// Create a new pool for a factory.<br>
>   AttributePool(AttributeFactory &factory) : Factory(factory), Head(nullptr) {}<br>
><br>
> -  /// Move the given pool's allocations to this pool.<br>
> -  AttributePool(AttributePool &pool) : Factory(pool.Factory), Head(pool.Head) {<br>
> -    pool.Head = nullptr;<br>
> -  }<br>
> -<br>
<br>
</span>Moving without R-value references is weird, but it seems to me like<br>
at least this was preventing double-ownership of the Head.<br>
<br>
I'm pretty sure now that this function has been removed, the copy<br>
constructor will be auto-generated.  Should you `= delete` it?</blockquote><div><br></div><div>Or, preferably, reinstate it but make it a move constructor.</div></div></div></div>