<p dir="ltr">On Nov 25, 2015 1:53 PM, "<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a> via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> hfinkel added inline comments.<br>
><br>
> ================<br>
> Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2783<br>
> @@ -2783,1 +2782,3 @@<br>
> +  "the newer semantic is provided here">,<br>
> +  InGroup<DiagGroup<"attribute-packed-for-bitfield-semantic-changed">>;<br>
>  def warn_transparent_union_attribute_field_size_align : Warning<<br>
> ----------------<br>
> Calling this "a semantic" reads oddly to me. This sounds better to me:<br>
><br>
>   def note_attribute_packed_for_bitfield_offset_changed : Warning<<br>
>     "the offset assigned to packed bit-field member %0 has changed with GCC version 4.4 - "</p>
<p dir="ltr">Please also remove the "has" here.</p>
<p dir="ltr">>     "the newer offset is used here">,<br>
>     InGroup<DiagGroup<"attribute-packed-bitfield-offset-changed">>;<br>
><br>
> ================<br>
> Comment at: lib/Sema/SemaDeclAttr.cpp:1040<br>
> @@ -1039,3 +1039,3 @@<br>
>      // If the alignment is less than or equal to 8 bits, the packed attribute<br>
>      // has no effect.<br>
>      if (!FD->getType()->isDependentType() &&<br>
> ----------------<br>
> This comment is now out of date?<br>
><br>
><br>
> <a href="http://reviews.llvm.org/D14872">http://reviews.llvm.org/D14872</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</p>