<div dir="ltr">Possible to test (unit test?) the bug that GCC accidentally found here?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 24, 2015 at 6:41 PM, Richard Smith via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rsmith<br>
Date: Tue Nov 24 20:41:42 2015<br>
New Revision: 254053<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254053&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254053&view=rev</a><br>
Log:<br>
Fix typo that was being SFINAE'd away (and apparently GCC 4.7.2 rejects-valid on this).<br>
<br>
Modified:<br>
    cfe/trunk/include/clang/AST/RecursiveASTVisitor.h<br>
<br>
Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=254053&r1=254052&r2=254053&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=254053&r1=254052&r2=254053&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/AST/RecursiveASTVisitor.h (original)<br>
+++ cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Tue Nov 24 20:41:42 2015<br>
@@ -291,10 +291,10 @@ private:<br>
   // class can take a queue, so if we're taking the second arm, make the first<br>
   // arm call our function rather than the derived class version.<br>
 #define TRAVERSE_STMT_BASE(NAME, CLASS, VAR, QUEUE)                            \<br>
-  (decltype(callableWithQueue<CLASS *>(&Derived::Traverse##NAME))::value       \<br>
+  (decltype(callableWithQueue<CLASS>(&Derived::Traverse##NAME))::value         \<br>
        ? static_cast<typename std::conditional<                                \<br>
              decltype(                                                         \<br>
-                 callableWithQueue<CLASS *>(&Derived::Traverse##NAME))::value, \<br>
+                 callableWithQueue<CLASS>(&Derived::Traverse##NAME))::value,   \<br>
              Derived &, RecursiveASTVisitor &>::type>(*this)                   \<br>
              .Traverse##NAME(static_cast<CLASS *>(VAR), QUEUE)                 \<br>
        : getDerived().Traverse##NAME(static_cast<CLASS *>(VAR)))<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>