<div dir="ltr">Could this initialization just be written as "mbstate_t mb = {}" & avoid the warning entirely (I'm not entirely sure what the warning was, but I imagine that'd avoid it)</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 24, 2015 at 5:06 PM, Marshall Clow via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: marshall<br>
Date: Tue Nov 24 19:06:36 2015<br>
New Revision: 254050<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=254050&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=254050&view=rev</a><br>
Log:<br>
Silence a -Wmissing-braces warning in the tests; mbstate_t is defined differently on different C libraries.<br>
<br>
Modified:<br>
    libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp?rev=254050&r1=254049&r2=254050&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp?rev=254050&r1=254049&r2=254050&view=diff</a><br>
==============================================================================<br>
--- libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/depr/depr.c.headers/wchar_h.pass.cpp Tue Nov 24 19:06:36 2015<br>
@@ -31,7 +31,15 @@<br>
<br>
 int main()<br>
 {<br>
+// mbstate_t comes from the underlying C library; it is defined (in C99) as:<br>
+//    a complete object type other than an array type that can hold the conversion<br>
+//    state information necessary to convert between sequences of multibyte<br>
+//    characters and wide characters<br>
+#pragma clang diagnostic push<br>
+#pragma clang diagnostic ignored "-Wmissing-braces"<br>
     mbstate_t mb = {0};<br>
+#pragma clang diagnostic pop<br>
+<br>
     size_t s = 0;<br>
     tm *tm = 0;<br>
     wint_t w = 0;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>