<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Good to know my spelling is at least consistently wrong :-).<div class=""><br class=""></div><div class="">I’ll fix this shortly.</div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 20, 2015, at 8:12 PM, Sean Silva <<a href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><br class="Apple-interchange-newline"><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Fri, Nov 20, 2015 at 2:09 PM, Chris Bieneman via cfe-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: cbieneman<br class="">Date: Fri Nov 20 16:09:06 2015<br class="">New Revision: 253721<br class=""><br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=253721&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=253721&view=rev</a><br class="">Log:<br class="">[CMake] Add support for specifying arguments to the bootstrap build.<br class=""><br class="">This adds support for three types of argument specifications for bootstrap builds:<br class=""><br class="">(1) Arguments prefixed with BOOTSTRAP_* will be passed through with the leading BOOTSTRAP_ removed.<br class="">(2) CLANG_BOOTSTRAP_PASSTHROUGH can specify a list of variables to be passed through as they are set.<br class="">(3) BOOTSTRAP_DEFAULT_PASSTHROUGH is a list of some default passthrough variables that are always passed through. Those variables include the version string and should only specify variables that are always expected to be the same between the stage1 and stage2<br class=""><br class="">Modified:<br class=""> <span class="Apple-converted-space"> </span>cfe/trunk/CMakeLists.txt<br class=""><br class="">Modified: cfe/trunk/CMakeLists.txt<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=253721&r1=253720&r2=253721&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=253721&r1=253720&r2=253721&view=diff</a><br class="">==============================================================================<br class="">--- cfe/trunk/CMakeLists.txt (original)<br class="">+++ cfe/trunk/CMakeLists.txt Fri Nov 20 16:09:06 2015<br class="">@@ -652,6 +652,36 @@ if (CLANG_ENABLE_BOOTSTRAP)<br class=""> set(verbose -DCMAKE_VERBOSE_MAKEFILE=On)<br class=""> endif()<br class=""><br class="">+ set(BOOTSTRAP_DEFAULT_PASSTHROUGH<br class="">+ PACKAGE_VERSION<br class="">+ LLVM_VERSION_MAJOR<br class="">+ LLVM_VERSION_MINOR<br class="">+ LLVM_VERSION_PATCH<br class="">+ LLVM_VERSION_SUFFIX<br class="">+ CLANG_REPOSITORY_STRING<br class="">+ CMAKE_MAKE_PROGRAM)<br class="">+<br class="">+ # Find all variables that start with BOOTSTRAP_ and populate a variable with<br class="">+ # them.<br class="">+ get_cmake_property(variableNames VARIABLES)<br class="">+ foreach(varaibleName ${variableNames})<br class="">+ if(varaibleName MATCHES "^BOOTSTRAP_")<br class="">+ string(SUBSTRING ${varaibleName} 10 -1 varName)<br class="">+ string(REPLACE ";" "\;" value "${${varaibleName}}")<br class="">+ list(APPEND PASSTHROUGH_VARIABLES<br class="">+ -D${varName}=${value})<br class="">+ endif()<br class="">+ endforeach()<br class="">+<br class="">+ # Populate the passthrough variables<br class="">+ foreach(varaibleName ${CLANG_BOOTSTRAP_PASSTHROUGH} ${BOOTSTRAP_DEFAULT_PASSTHROUGH})<br class="">+ if(${varaibleName})<br class=""></blockquote><div class=""><br class=""></div><div class="">typo: "varaibleName".</div><div class=""><br class=""></div><div class="">I saw one in r253720 as well.</div><div class=""><br class=""></div><div class="">-- Sean Silva</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">+ string(REPLACE ";" "\;" value ${${varaibleName}})<br class="">+ list(APPEND PASSTHROUGH_VARIABLES<br class="">+ -D${varaibleName}=${value})<br class="">+ endif()<br class="">+ endforeach()<br class="">+<br class=""> ExternalProject_Add(bootstrap<br class=""> DEPENDS clang ${LTO_DEP}<br class=""> PREFIX bootstrap<br class="">@@ -664,6 +694,7 @@ if (CLANG_ENABLE_BOOTSTRAP)<br class=""> # seem to work, so instead I'm passing this through<br class=""> -DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}<br class=""> ${CLANG_BOOTSTRAP_CMAKE_ARGS}<br class="">+ ${PASSTHROUGH_VARIABLES}<br class=""> -DCMAKE_CXX_COMPILER=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang++<br class=""> -DCMAKE_C_COMPILER=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang<br class=""> -DCMAKE_ASM_COMPILER=${LLVM_RUNTIME_OUTPUT_INTDIR}/clang<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a></blockquote></div></div></blockquote></div><br class=""></div></body></html>