<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:12.8px">This changes the linker from old-gnu to gnu. Are you sure you want to<br></span><span style="font-size:12.8px">that?</span></blockquote><div>Originally I didn't actually mean to commit that. I had been working on some stuff locally.<br>Pointing to the new one should be fine as neither work for COFF atm anyway so no point in having it point to the old one.</div>I'll make lld more verbose about this when it receives this emulation target.<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:12.8px">I don't think the new linker takes a -target option. In any<br></span><span style="font-size:12.8px">case, it needs a test.</span></blockquote>You are correct the new linker does not support -target. I reverted this in <span style="font-size:12.8px">rL253874.<br><br></span></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 23, 2015 at 7:05 AM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This changes the linker from old-gnu to gnu. Are you sure you want to<br>
that? I don't think the new linker takes a -target option. In any<br>
case, it needs a test.<br>
<br>
Cheers,<br>
Rafael<br>
<br>
<br>
On 22 November 2015 at 00:40, Martell Malone via cfe-commits<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: martell<br>
> Date: Sat Nov 21 23:40:06 2015<br>
> New Revision: 253813<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253813&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253813&view=rev</a><br>
> Log:<br>
> Driver: Specifically tell the linker the target for mingw-w64<br>
><br>
> Cross compiling from linux and OSX results in Error: Exec format.<br>
> This is because the linker is expecting ELF formated objects.<br>
> By passing the target we can explicitly tell the linker that<br>
> it should be linking COFF objects regardless of the host.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Driver/Tools.cpp<br>
><br>
> Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=253813&r1=253812&r2=253813&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=253813&r1=253812&r2=253813&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/Tools.cpp Sat Nov 21 23:40:06 2015<br>
> @@ -9478,7 +9478,14 @@ void MinGW::Linker::ConstructJob(Compila<br>
>    StringRef LinkerName = Args.getLastArgValue(options::OPT_fuse_ld_EQ, "ld");<br>
>    if (LinkerName.equals_lower("lld")) {<br>
>      CmdArgs.push_back("-flavor");<br>
> -    CmdArgs.push_back("old-gnu");<br>
> +    CmdArgs.push_back("gnu");<br>
> +    CmdArgs.push_back("-target");<br>
> +    if (TC.getArch() == llvm::Triple::x86)<br>
> +      CmdArgs.push_back("i686--windows-gnu");<br>
> +    if (TC.getArch() == llvm::Triple::x86_64)<br>
> +      CmdArgs.push_back("x86_64--windows-gnu");<br>
> +    if (TC.getArch() == llvm::Triple::arm)<br>
> +      CmdArgs.push_back("armv7--windows-gnu");<br>
>    } else if (!LinkerName.equals_lower("ld")) {<br>
>      D.Diag(diag::err_drv_unsupported_linker) << LinkerName;<br>
>    }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>