<div dir="ltr">On Tue, Nov 17, 2015 at 5:06 PM, Reid Kleckner via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Tue Nov 17 19:06:39 2015<br>
New Revision: 253418<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253418&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253418&view=rev</a><br>
Log:<br>
Try to fix leak in CXStringSet from r252853<br>
<br>
Modified:<br>
    cfe/trunk/tools/libclang/CXString.cpp<br>
<br>
Modified: cfe/trunk/tools/libclang/CXString.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CXString.cpp?rev=253418&r1=253417&r2=253418&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CXString.cpp?rev=253418&r1=253417&r2=253418&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/tools/libclang/CXString.cpp (original)<br>
+++ cfe/trunk/tools/libclang/CXString.cpp Tue Nov 17 19:06:39 2015<br>
@@ -186,6 +186,8 @@ void clang_disposeString(CXString string<br>
 }<br>
<br>
 void clang_disposeStringSet(CXStringSet *set) {<br>
+  for (unsigned SI = 0, SE = set->Count; SI < SE; ++SI)<br>
+    clang_disposeString(set->Strings[SI]);<br>
   delete[] set->Strings;<br>
   delete set;<br>
 }<br><br></blockquote><div><br></div><div>Thanks for fixing this!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>