<div dir="ltr">Note that due to this change we're hitting an assert at lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value *tryEmitFMulAdd(const (anonymous namespace)::BinOpInfo &, const clang::CodeGen::CodeGenFunction &, clang::CodeGen::CGBuilderTy &, bool): LHSBinOp->getNumUses(<div>) == 0 && "Operations with multiple uses shouldn't be contracted."</div><div><br></div><div>Don't have a small repro yet :(</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 17, 2015 at 1:39 PM Hal Finkel via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">----- Original Message -----<br>
> From: "Renato Golin via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
> To: "Stephen Canon" <<a href="mailto:scanon@apple.com" target="_blank">scanon@apple.com</a>><br>
> Cc: "Clang Commits" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>><br>
> Sent: Tuesday, November 17, 2015 3:51:23 AM<br>
> Subject: Re: r253269 - Make FP_CONTRACT ON the default.<br>
><br>
> On 16 November 2015 at 23:09, Stephen Canon via cfe-commits<br>
> <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> > Author: scanon<br>
> > Date: Mon Nov 16 17:09:11 2015<br>
> > New Revision: 253269<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253269&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253269&view=rev</a><br>
> > Log:<br>
> > Make FP_CONTRACT ON the default.<br>
> ><br>
> > Differential Revision: D14200<br>
><br>
> Hi Stephen,<br>
><br>
> It seems your commit in the blame list is the only one that affects<br>
> AArch64 directly:<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2388" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2388</a><br>
><br>
> I haven't bisected yet, but would be good if you could try those<br>
> tests<br>
> locally, just to make sure it wasn't your commit, and revert if it<br>
> was, to fix offline.<br>
<br>
The test suite already has logic to add -ffp-contract=off on PowerPC so that we can compare to the binary outputs. We may need to do this now for all targets, at least until be come up with a better solution.<br>
<br>
 -Hal<br>
<br>
><br>
> cheers,<br>
> --renato<br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
><br>
<br>
--<br>
Hal Finkel<br>
Assistant Computational Scientist<br>
Leadership Computing Facility<br>
Argonne National Laboratory<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>