<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I'm fine with this approach. How about I leave the file in place,
but replace the contents with a "using DataRecursiveASTVisitor =
RecursiveASTVisitor;" and see what breaks? That way I won't need to
go through a large retrofit.<br>
<br>
<div class="moz-cite-prefix">On 11/16/2015 3:28 PM, Richard Smith
wrote:<br>
</div>
<blockquote
cite="mid:CAOfiQqk1RSgTk9drkkNxaC+RH84TnHYZNDouOyhLorARApC9AA@mail.gmail.com"
type="cite">
<div dir="ltr">Rather than trying to maintain the horrible
duplication between DataRecursiveASTVisitor and
RecursiveASTVisitor, can we just delete DataRecursiveASTVisitor?
RecursiveASTVisitor is data-recursive too these days (and has a
smarter implementation than DataRecursiveASTVisitor's from what
I can see), but doesn't yet apply data recursion in so many
cases.<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Nov 16, 2015 at 1:07 PM,
Argyrios Kyrtzidis <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:akyrtzi@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a></a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM.<br>
<div class="HOEnZb">
<div class="h5"><br>
> On Nov 16, 2015, at 12:32 PM, Ben Craig <<a
moz-do-not-send="true"
href="mailto:ben.craig@codeaurora.org"><a class="moz-txt-link-abbreviated" href="mailto:ben.craig@codeaurora.org">ben.craig@codeaurora.org</a></a>>
wrote:<br>
><br>
> bcraig added a comment.<br>
><br>
> Ping. Note that the test is basically a copy /
paste job, and the new code in DataRecursiveASTVisitor.h
is a very direct translation from the 'regular'
RecursiveASTVisitor.h.<br>
><br>
><br>
> <a moz-do-not-send="true"
href="http://reviews.llvm.org/D14506" rel="noreferrer"
target="_blank">http://reviews.llvm.org/D14506</a><br>
><br>
><br>
><br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
</pre>
</body>
</html>