<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 13, 2015, at 4:20 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Nov 13, 2015 at 4:03 PM, Ben Langmuir via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">This time sending to the right list address.</blockquote><div class=""><br class=""></div><div class="">Likewise =)</div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">> On Nov 13, 2015, at 4:00 PM, Ben Langmuir <<a href="mailto:blangmuir@apple.com" class="">blangmuir@apple.com</a>> wrote:<br class="">
><br class="">
> Hey Richard,<br class="">
><br class="">
> After your commit r233345 we started diagnosing “redefinition” errors for typedefs of anonymous tags that are *not visible* in case like this:<br class="">
><br class="">
> module that isn’t imported:<br class="">
> typedef struct { … } Foo_t;<br class="">
> source file:<br class="">
> typedef struct { … } Foo_t;<br class="">
><br class="">
> I think the only change needed is to not consider these anonymous tags to be the same entity unless we’re in C++. Patch attached.<br class=""></div></div></blockquote><div class=""><br class=""></div><div class=""><span style="font-size:12.8px" class="">Looks fine. Do we also miscompute the linkage for these things in C (where types don't really have linkage), or is this just a problem because we bail out before we hit the isExternallyVisible check?</span></div></div></div></div>
</div></blockquote></div><div class=""><br class=""></div><div class="">Ack, my copy of clang was a couple of days old and I guess you’ve been working in this area! My patch is no longer sufficient...</div></body></html>