<div dir="ltr">Hi David,<div><br></div><div>Honestly, I really don't know. I just updated them due to a change in LLVM - I hadn't considered doing an audit.</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 12 Nov 2015 at 16:08 David Blaikie via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Nov 12, 2015 at 2:56 AM, James Molloy via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jamesm<br>
Date: Thu Nov 12 04:56:51 2015<br>
New Revision: 252872<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252872&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=252872&view=rev</a><br>
Log:<br>
Update clang regression tests for 'norecurse'<br>
<br>
FunctionAttrs has just been taught how to infer 'norecurse'. Update clang tests for LLVM r252871.<br></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Do all these tests need to run FunctionAttrs? Could some/all of them be switched to use -disable-llvm-optzns?</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    cfe/trunk/test/CodeGen/attr-minsize.cpp<br>
    cfe/trunk/test/CodeGen/function-attributes.c<br>
    cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp<br>
    cfe/trunk/test/CodeGenCXX/member-initializers.cpp<br>
    cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp<br>
<br>
Modified: cfe/trunk/test/CodeGen/attr-minsize.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-minsize.cpp?rev=252872&r1=252871&r2=252872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-minsize.cpp?rev=252872&r1=252871&r2=252872&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/attr-minsize.cpp (original)<br>
+++ cfe/trunk/test/CodeGen/attr-minsize.cpp Thu Nov 12 04:56:51 2015<br>
@@ -76,4 +76,4 @@ void test5<float>(float arg);<br>
<br>
 // Oz: attributes [[MINSIZE]] = { minsize{{.*}} }<br>
<br>
-// OTHER: attributes [[MS]] = { minsize nounwind{{.*}} }<br>
+// OTHER: attributes [[MS]] = { minsize {{(norecurse )?}}nounwind{{.*}} }<br>
<br>
Modified: cfe/trunk/test/CodeGen/function-attributes.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/function-attributes.c?rev=252872&r1=252871&r2=252872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/function-attributes.c?rev=252872&r1=252871&r2=252872&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/function-attributes.c (original)<br>
+++ cfe/trunk/test/CodeGen/function-attributes.c Thu Nov 12 04:56:51 2015<br>
@@ -128,9 +128,9 @@ void f20(void) {<br>
   _setjmp(0);<br>
 }<br>
<br>
-// CHECK: attributes [[NUW]] = { nounwind optsize readnone{{.*}} }<br>
-// CHECK: attributes [[AI]] = { alwaysinline nounwind optsize readnone{{.*}} }<br>
-// CHECK: attributes [[ALIGN]] = { nounwind optsize readnone alignstack=16{{.*}} }<br>
+// CHECK: attributes [[NUW]] = { norecurse nounwind optsize readnone{{.*}} }<br>
+// CHECK: attributes [[AI]] = { alwaysinline norecurse nounwind optsize readnone{{.*}} }<br>
+// CHECK: attributes [[ALIGN]] = { norecurse nounwind optsize readnone alignstack=16{{.*}} }<br>
 // CHECK: attributes [[RT]] = { nounwind optsize returns_twice{{.*}} }<br>
 // CHECK: attributes [[NR]] = { noreturn nounwind optsize }<br>
 // CHECK: attributes [[NUW_RN]] = { nounwind optsize readnone }<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp?rev=252872&r1=252871&r2=252872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp?rev=252872&r1=252871&r2=252872&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp Thu Nov 12 04:56:51 2015<br>
@@ -35,4 +35,4 @@ int f() {<br>
   return count;<br>
 }<br>
<br>
-// CHECK: attributes [[NUW]] = { nounwind{{.*}} }<br>
+// CHECK: attributes [[NUW]] = { norecurse nounwind{{.*}} }<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/member-initializers.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/member-initializers.cpp?rev=252872&r1=252871&r2=252872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/member-initializers.cpp?rev=252872&r1=252871&r2=252872&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/member-initializers.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/member-initializers.cpp Thu Nov 12 04:56:51 2015<br>
@@ -32,4 +32,4 @@ int test_fold() {<br>
   return A(2).i;<br>
 }<br>
<br>
-// CHECK: attributes [[NUW_RN]] = { nounwind readnone{{.*}} }<br>
+// CHECK: attributes [[NUW_RN]] = { norecurse nounwind readnone{{.*}} }<br>
<br>
Modified: cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp?rev=252872&r1=252871&r2=252872&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp?rev=252872&r1=252871&r2=252872&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp (original)<br>
+++ cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp Thu Nov 12 04:56:51 2015<br>
@@ -295,4 +295,4 @@ U u;<br>
 // CHECK-GLOBAL: @_ZN11IndirectPDM1uE = global %"union.IndirectPDM::U" { %union.anon { i64 -1 } }, align 8<br>
 }<br>
<br>
-// CHECK-O3: attributes [[NUW]] = { nounwind readnone{{.*}} }<br>
+// CHECK-O3: attributes [[NUW]] = { norecurse nounwind readnone{{.*}} }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>