<p dir="ltr"><br>
On Oct 25, 2015 3:05 PM, "Benjamin Kramer via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: d0k<br>
> Date: Sun Oct 25 17:03:00 2015<br>
> New Revision: 251265<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=251265&view=rev">http://llvm.org/viewvc/llvm-project?rev=251265&view=rev</a><br>
> Log:<br>
> assert(false) -> llvm_unreachable.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp?rev=251265&r1=251264&r2=251265&view=diff">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp?rev=251265&r1=251264&r2=251265&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Sun Oct 25 17:03:00 2015<br>
> @@ -82,7 +82,7 @@ getZeroLiteralToCompareWithForGivenType(<br>
>      return Context.getLangOpts().CPlusPlus11 ? "nullptr" : "0";<br>
><br>
>    default:<br>
> -    assert(false && "Unexpected cast kind");<br>
> +    llvm_unreachable("Unexpected cast kind");<br>
>    }<br>
>    return "";</p>
<p dir="ltr">I think you can drop the return here, then?</p>
<p dir="ltr">>  }<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</p>