<p dir="ltr">Ah, I see Benjamin got to this in 251265</p>
<div class="gmail_quote">On Oct 25, 2015 9:54 PM, "David Blaikie" <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr"><br>
On Oct 25, 2015 2:47 PM, "Daniel Jasper via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: djasper<br>
> Date: Sun Oct 25 16:44:55 2015<br>
> New Revision: 251262<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=251262&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=251262&view=rev</a><br>
> Log:<br>
> [clang-tidy] Add return value for non-assert builds.<br>
><br>
> Modified:<br>
>     clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp<br>
><br>
> Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp?rev=251262&r1=251261&r2=251262&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp?rev=251262&r1=251261&r2=251262&view=diff</a><br>
> ==============================================================================<br>
> --- clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp (original)<br>
> +++ clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Sun Oct 25 16:44:55 2015<br>
> @@ -84,6 +84,7 @@ getZeroLiteralToCompareWithForGivenType(<br>
>    default:<br>
>      assert(false && "Unexpected cast kind");</p>
<p dir="ltr">Prefer llvm_unreachable over assert(false) and the return shouldn't be needed. (He unreachable will amount to a call to a noreturn function in both asserts and non-asserts builds)</p>
<p dir="ltr">>    }<br>
> +  return "";<br>
>  }<br>
><br>
>  bool isUnaryLogicalNotOperator(const Stmt *Statement) {<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</p>
</blockquote></div>