<div dir="ltr">Hi Jonas,<div><br></div><div>Thanks for being patient and sorry for the failed first attempt. I think I fixed it in r251100.</div><div><br></div><div>I swear I'm normally more careful.</div><div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 22, 2015 at 8:34 PM, Hahnfeld, Jonas <span dir="ltr"><<a href="mailto:Hahnfeld@itc.rwth-aachen.de" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
thanks for the attempt to fix this, but this isn't working for in-tree builds<br>
of libcxx:<br>
CMake Error at projects/libcxx/lib/cmake_install.cmake:56 (FILE):<br>
  file INSTALL cannot find<br>
  "<<<BUILD>>>/projects/libcxx/lib/libc++.so"<br>
<br>
It is located at <<<BUILD>>>/lib/libc++.so. CMake version is 2.8.12.2 which<br>
should be the minimum required version when building all LLVM projects.<br>
<br>
Cheers,<br>
Jonas<br>
<div class="HOEnZb"><div class="h5"><br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org">cfe-commits-bounces@lists.llvm.org</a>] On Behalf<br>
> Of Eric Fiselier via cfe-commits<br>
> Sent: Thursday, October 22, 2015 11:24 PM<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Subject: [libcxx] r251065 - Dont required CMake 3 to install a linker script<br>
><br>
> Author: ericwf<br>
> Date: Thu Oct 22 16:24:01 2015<br>
> New Revision: 251065<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=251065&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=251065&view=rev</a><br>
> Log:<br>
> Dont required CMake 3 to install a linker script<br>
><br>
> Modified:<br>
>     libcxx/trunk/lib/CMakeLists.txt<br>
><br>
> Modified: libcxx/trunk/lib/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/libcxx/trunk/lib/CMakeLists.txt?rev=251065&r1=251064&r2=251065&<br>
> view=diff<br>
> ==========================================================<br>
> ====================<br>
> --- libcxx/trunk/lib/CMakeLists.txt (original)<br>
> +++ libcxx/trunk/lib/CMakeLists.txt Thu Oct 22 16:24:01 2015<br>
> @@ -154,7 +154,6 @@ if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT)<br>
>    )<br>
>  endif()<br>
><br>
> -<br>
>  if (LIBCXX_INSTALL_LIBRARY)<br>
>    install(TARGETS cxx<br>
>      LIBRARY DESTINATION lib${LIBCXX_LIBDIR_SUFFIX} COMPONENT libcxx<br>
> @@ -163,7 +162,9 @@ if (LIBCXX_INSTALL_LIBRARY)<br>
>    # NOTE: This install command must go after the cxx install command<br>
> otherwise<br>
>    # it will not be executed after the library symlinks are installed.<br>
>    if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT)<br>
> -    install(FILES "$<TARGET_LINKER_FILE:cxx>"<br>
> +    # Replace the libc++ filename with $<TARGET_LINKER_FILE:cxx><br>
> +    # after we required CMake 3.0.<br>
> +    install(FILES<br>
> "${CMAKE_CURRENT_BINARY_DIR}/libc++${CMAKE_SHARED_LIBRARY_SUFF<br>
> IX}"<br>
>        DESTINATION lib${LIBCXX_LIBDIR_SUFFIX}<br>
>        COMPONENT libcxx)<br>
>    endif()<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>