<div dir="ltr">Nevermind, I see this was floated/discussed in the review thread of the original commit ( <span style="font-family:monospace">250418 )</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 20, 2015 at 11:46 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Tue, Oct 20, 2015 at 12:50 AM, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Tue Oct 20 02:50:21 2015<br>
New Revision: 250803<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250803&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250803&view=rev</a><br>
Log:<br>
Put back dead code that's used out-of-tree.<br></blockquote><div><br></div></span><div>Might be worth adding some unit tests (& comments there to give people some idea about it)?</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Partially reverts r250418.<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp<br>
cfe/trunk/lib/Tooling/Core/CMakeLists.txt<br>
cfe/trunk/unittests/Tooling/CMakeLists.txt<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp?rev=250803&r1=250802&r2=250803&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp?rev=250803&r1=250802&r2=250803&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CodeGenABITypes.cpp Tue Oct 20 02:50:21 2015<br>
@@ -36,3 +36,33 @@ CodeGenABITypes::CodeGenABITypes(ASTCont<br>
// Explicitly out-of-line because ~CodeGenModule() is private but<br>
// CodeGenABITypes.h is part of clang's API.<br>
CodeGenABITypes::~CodeGenABITypes() = default;<br>
+<br>
+const CGFunctionInfo &<br>
+CodeGenABITypes::arrangeObjCMessageSendSignature(const ObjCMethodDecl *MD,<br>
+ QualType receiverType) {<br>
+ return CGM->getTypes().arrangeObjCMessageSendSignature(MD, receiverType);<br>
+}<br>
+<br>
+const CGFunctionInfo &<br>
+CodeGenABITypes::arrangeFreeFunctionType(CanQual<FunctionProtoType> Ty) {<br>
+ return CGM->getTypes().arrangeFreeFunctionType(Ty);<br>
+}<br>
+<br>
+const CGFunctionInfo &<br>
+CodeGenABITypes::arrangeFreeFunctionType(CanQual<FunctionNoProtoType> Ty) {<br>
+ return CGM->getTypes().arrangeFreeFunctionType(Ty);<br>
+}<br>
+<br>
+const CGFunctionInfo &<br>
+CodeGenABITypes::arrangeCXXMethodType(const CXXRecordDecl *RD,<br>
+ const FunctionProtoType *FTP) {<br>
+ return CGM->getTypes().arrangeCXXMethodType(RD, FTP);<br>
+}<br>
+<br>
+const CGFunctionInfo &CodeGenABITypes::arrangeFreeFunctionCall(<br>
+ CanQualType returnType, ArrayRef<CanQualType> argTypes,<br>
+ FunctionType::ExtInfo info, RequiredArgs args) {<br>
+ return CGM->getTypes().arrangeLLVMFunctionInfo(<br>
+ returnType, /*IsInstanceMethod=*/false, /*IsChainCall=*/false, argTypes,<br>
+ info, args);<br>
+}<br>
<br>
Modified: cfe/trunk/lib/Tooling/Core/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Core/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Core/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Tooling/Core/CMakeLists.txt (original)<br>
+++ cfe/trunk/lib/Tooling/Core/CMakeLists.txt Tue Oct 20 02:50:21 2015<br>
@@ -1,6 +1,7 @@<br>
set(LLVM_LINK_COMPONENTS support)<br>
<br>
add_clang_library(clangToolingCore<br>
+ Lookup.cpp<br>
Replacement.cpp<br>
<br>
LINK_LIBS<br>
<br>
Modified: cfe/trunk/unittests/Tooling/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Tooling/CMakeLists.txt?rev=250803&r1=250802&r2=250803&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/unittests/Tooling/CMakeLists.txt (original)<br>
+++ cfe/trunk/unittests/Tooling/CMakeLists.txt Tue Oct 20 02:50:21 2015<br>
@@ -6,6 +6,7 @@ set(LLVM_LINK_COMPONENTS<br>
add_clang_unittest(ToolingTests<br>
CommentHandlerTest.cpp<br>
CompilationDatabaseTest.cpp<br>
+ LookupTest.cpp<br>
ToolingTest.cpp<br>
RecursiveASTVisitorTest.cpp<br>
RecursiveASTVisitorTestCallVisitor.cpp<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>