<div dir="ltr">Filipe,<div><br></div><div>FYI, this change appears to introduce a somewhat subtle problem. clang compiled with itself starts producing (false positive?) warnings about uninitialized variables. I didn't get a chance to dig deeper yet.</div><div><br></div><div>--Artem</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 16, 2015 at 8:07 AM, Filipe Cabecinhas via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Fri Oct 16 10:07:48 2015<br>
New Revision: 250514<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250514&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250514&view=rev</a><br>
Log:<br>
PS4: Make sure to add the sanitizer runtime before any linker input<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Tools.cpp<br>
<br>
Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=250514&r1=250513&r2=250514&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=250514&r1=250513&r2=250514&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Tools.cpp Fri Oct 16 10:07:48 2015<br>
@@ -10017,6 +10017,8 @@ static void ConstructPS4LinkJob(const To<br>
     assert(Output.isNothing() && "Invalid output.");<br>
   }<br>
<br>
+  AddPS4SanitizerArgs(ToolChain, CmdArgs);<br>
+<br>
   Args.AddAllArgs(CmdArgs, options::OPT_L);<br>
   Args.AddAllArgs(CmdArgs, options::OPT_T_Group);<br>
   Args.AddAllArgs(CmdArgs, options::OPT_e);<br>
@@ -10034,7 +10036,6 @@ static void ConstructPS4LinkJob(const To<br>
   }<br>
<br>
   AddPS4ProfileRT(ToolChain, Args, CmdArgs);<br>
-  AddPS4SanitizerArgs(ToolChain, CmdArgs);<br>
<br>
   const char *Exec = Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld"));<br>
<br>
@@ -10087,6 +10088,8 @@ static void ConstructGoldLinkJob(const T<br>
     assert(Output.isNothing() && "Invalid output.");<br>
   }<br>
<br>
+  AddPS4SanitizerArgs(ToolChain, CmdArgs);<br>
+<br>
   if (!Args.hasArg(options::OPT_nostdlib) &&<br>
       !Args.hasArg(options::OPT_nostartfiles)) {<br>
     const char *crt1 = NULL;<br>
@@ -10214,7 +10217,6 @@ static void ConstructGoldLinkJob(const T<br>
   }<br>
<br>
   AddPS4ProfileRT(ToolChain, Args, CmdArgs);<br>
-  AddPS4SanitizerArgs(ToolChain, CmdArgs);<br>
<br>
   const char *Exec =<br>
 #ifdef LLVM_ON_WIN32<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">--Artem Belevich</div></div>
</div>