<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On Oct 15, 2015, at 1:42 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" class="">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:aprantl@apple.com" target="_blank" class="">aprantl@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div class="" style="word-wrap: break-word;"><span class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Oct 14, 2015, at 5:07 PM, Richard Smith <<a href="mailto:richard@metafoo.co.uk" target="_blank" class="">richard@metafoo.co.uk</a>> wrote:</div><div class=""><div dir="ltr" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">Ack, there are non-modular headers in the Darwin module. =( I seem to recall that they're not version-locked to your compiler, so we've got to support them as-is?</div><div class=""><br class=""></div><div class="">If we can't turn on local submodule visibility, then we need a module map for libc++ that covers all of its headers. I'll look into pruning the include path when building a module from an implicitly-loaded module map.</div></div></div></div></div></blockquote></div><br class=""></span><div class="">The attached patch implements this in the most hacky way; with it I can successfully compile the first few hundred files of LLVM.</div></div></blockquote><div class=""><br class=""></div><div class="">Great, it looks like this plan should work then. What failure do you eventually hit? Does it look related to these <foo.h> changes?</div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">So far I fixed <span class="" style="font-family: Menlo-Regular;">250446</span> and <span class="" style="font-family: Menlo-Regular;">250459 </span>which were both just missing include files. I’m puzzled by <span class="" style="font-family: Menlo-Regular;">250459</span> though, as there is nothing Darwin-specific about the change. I’ll keep iterating and will let you know if there are any libc++-related problems.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""><br class=""></div><div class="">I'm working on a more refined version of the approach I described earlier; I'll mail you a patch to test when I have it finished.</div></div></div></div></div></blockquote></div><br class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">That sounds great.</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">thanks,</div><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">adrian</div></div></blockquote><br class=""></div><div>Here’s a weird one:</div><div style="font-size: 9px;"><br class=""></div><div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class=""><b class="">../lib/Transforms/Scalar/ScalarReplAggregates.cpp:1031:6: </b><span style="font-variant-ligatures: no-common-ligatures; color: #c33720" class=""><b class="">error: </b></span><b class="">'SROA' is not a class, namespace, or enumeration</b></div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class="">bool SROA::runOnFunction(Function &F) {</div><div style="margin: 0px; line-height: normal; font-family: Menlo; color: rgb(52, 189, 38); font-size: 11px;" class=""><b class=""> ^</b></div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class=""><b class="">../lib/Transforms/Scalar/ScalarReplAggregates.cpp:1031:6: </b><span style="font-variant-ligatures: no-common-ligatures; color: #c33720" class=""><b class="">error: </b></span><b class="">reference to 'SROA' is ambiguous</b></div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class=""><b class="">../include/llvm/Transforms/Scalar/SROA.h:54:7: note: </b>candidate found by name lookup is 'llvm::SROA'</div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class="">class SROA {</div><div style="margin: 0px; line-height: normal; font-family: Menlo; color: rgb(52, 189, 38); font-size: 11px;" class=""><b class=""> ^</b></div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class=""><b class="">../lib/Transforms/Scalar/ScalarReplAggregates.cpp:63:10: note: </b>candidate found by name lookup is '(anonymous namespace)::SROA'</div><div style="margin: 0px; line-height: normal; font-family: Menlo; font-size: 11px;" class=""> struct SROA : public FunctionPass {</div><div style="margin: 0px; line-height: normal; font-family: Menlo; color: rgb(52, 189, 38); font-size: 11px;" class=""><b class=""> ^</b></div><div class=""><br class=""></div></div>this doesn’t look Darwin-specific at all. Assuming that the Linux module build works, why am I seeing this?<div class=""><br class=""></div><div class="">— adrian</div></body></html>