<div dir="ltr">I'd say that the SourceLocation::isInvalid is more confusing than useful. Not sure why it was added in the first place.<br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 3, 2015 at 12:46 PM, Yaron Keren via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Author: yrnkrn<br>
Date: Sat Oct 3 05:46:20 2015<br>
New Revision: 249235<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=249235&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=249235&view=rev</a><br>
Log:<br>
Replace double negation of !FileID.isInvalid() with FileID.isValid().<br>
+couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228.<br>
<br>
<br>
Modified:<br>
</span> clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp<br>
clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp<br>
clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp<br>
clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp?rev=249235&r1=249234&r2=249235&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp?rev=249235&r1=249234&r2=249235&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-apply-replacements/tool/ClangApplyReplacementsMain.cpp Sat Oct 3 05:46:20 2015<br>
@@ -118,7 +118,7 @@ getRewrittenData(const std::vector<tooli<br>
const clang::FileEntry *Entry = Files.getFile(FileName);<br>
assert(Entry && "Expected an existing file");<br>
FileID ID = SM.translateFile(Entry);<br>
- assert(!ID.isInvalid() && "Expected a valid FileID");<br>
+ assert(ID.isValid() && "Expected a valid FileID");<br>
const RewriteBuffer *Buffer = Rewrites.getRewriteBufferFor(ID);<br>
Result = std::string(Buffer->begin(), Buffer->end());<br>
<br>
<br>
Modified: clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp?rev=249235&r1=249234&r2=249235&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp?rev=249235&r1=249234&r2=249235&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-modernize/Core/IncludeDirectives.cpp Sat Oct 3 05:46:20 2015<br>
@@ -354,7 +354,7 @@ bool IncludeDirectives::hasInclude(const<br>
Replacement IncludeDirectives::addAngledInclude(const clang::FileEntry *File,<br>
llvm::StringRef Include) {<br>
FileID FID = Sources.translateFile(File);<br>
- assert(!FID.isInvalid() && "Invalid file entry given!");<br>
+ assert(FID.isValid() && "Invalid file entry given!");<br>
<br>
if (hasInclude(File, Include))<br>
return Replacement();<br>
<br>
Modified: clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp?rev=249235&r1=249234&r2=249235&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp?rev=249235&r1=249234&r2=249235&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-modernize/LoopConvert/LoopActions.cpp Sat Oct 3 05:46:20 2015<br>
@@ -578,7 +578,7 @@ bool ForLoopIndexUseVisitor::TraverseMem<br>
Context->getLangOpts());<br>
// If something complicated is happening (i.e. the next token isn't an<br>
// arrow), give up on making this work.<br>
- if (!ArrowLoc.isInvalid()) {<br>
+ if (ArrowLoc.isValid()) {<br>
Usages.push_back(Usage(ResultExpr, /*IsArrow=*/true,<br>
SourceRange(Base->getExprLoc(), ArrowLoc)));<br>
return true;<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp?rev=249235&r1=249234&r2=249235&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp?rev=249235&r1=249234&r2=249235&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/modernize/LoopConvertUtils.cpp Sat Oct 3 05:46:20 2015<br>
@@ -559,7 +559,7 @@ bool ForLoopIndexUseVisitor::TraverseMem<br>
Context->getLangOpts());<br>
// If something complicated is happening (i.e. the next token isn't an<br>
// arrow), give up on making this work.<br>
- if (!ArrowLoc.isInvalid()) {<br>
+ if (ArrowLoc.isValid()) {<br>
addUsage(Usage(ResultExpr, Usage::UK_MemberThroughArrow,<br>
SourceRange(Base->getExprLoc(), ArrowLoc)));<br>
return true;<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>