<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 6, 2015 at 8:04 AM, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Tue Oct  6 10:04:13 2015<br>
New Revision: 249413<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=249413&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=249413&view=rev</a><br>
Log:<br>
[Tooling] Don't run a tool invocation without a FileManager.<br>
<br>
Fixes a crash regression from r249410.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Tooling/Tooling.cpp<br>
<br>
Modified: cfe/trunk/lib/Tooling/Tooling.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?rev=249413&r1=249412&r2=249413&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?rev=249413&r1=249412&r2=249413&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Tooling/Tooling.cpp (original)<br>
+++ cfe/trunk/lib/Tooling/Tooling.cpp Tue Oct  6 10:04:13 2015<br>
@@ -455,8 +455,10 @@ std::unique_ptr<ASTUnit> buildASTFromCod<br>
<br>
   std::vector<std::unique_ptr<ASTUnit>> ASTs;<br>
   ASTBuilderAction Action(ASTs);<br>
+  llvm::IntrusiveRefCntPtr<FileManager> Files(<br>
+      new FileManager(FileSystemOptions()));<br>
   ToolInvocation Invocation(getSyntaxOnlyToolArgs(Args, FileNameRef), &Action,<br>
-                            nullptr, PCHContainerOps);<br>
+                            Files.get(), PCHContainerOps);<br></blockquote><div><br></div><div>Why is this a pointer parameter instead of a reference?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   SmallString<1024> CodeStorage;<br>
   Invocation.mapVirtualFile(FileNameRef,<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>