<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 2, 2015 at 1:58 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Tom,<br>
<br>
I would like this patch merged into 3.7.1.<br>
Marshall can you please approve this?<br></blockquote><div><br></div><div>Looks fine to me.</div><div><br></div><div>-- Marshall</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
/Eric<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Tue, Sep 22, 2015 at 12:55 PM, Dimitry Andric via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: dim<br>
> Date: Tue Sep 22 13:55:37 2015<br>
> New Revision: 248313<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=248313&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=248313&view=rev</a><br>
> Log:<br>
> Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.<br>
><br>
> Summary:<br>
> In rL241532, atomic_support.h was added, which provides handling of<br>
> atomic operations for libc++.  When atomic builtins are not available,<br>
> it emits a warning about being unsupported, but it still provides a<br>
> number of stubs for the required functions.<br>
><br>
> However, it misses a stub for `__libcpp_relaxed_store()`.  Add it, by<br>
> using the same implementation as for `__libcpp_atomic_store()`.<br>
><br>
> (Note that I encountered this on arm-freebsd, which still defaults to<br>
> armv4, and does not have the runtime libcalls to support atomic<br>
> builtins.  For now, I have simply disabled using them.)<br>
><br>
> Reviewers: mclow.lists, EricWF<br>
><br>
> Subscribers: theraven, cfe-commits, jroelofs, majnemer, aemerson<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D13051" rel="noreferrer" target="_blank">http://reviews.llvm.org/D13051</a><br>
><br>
> Modified:<br>
>     libcxx/trunk/src/include/atomic_support.h<br>
><br>
> Modified: libcxx/trunk/src/include/atomic_support.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/include/atomic_support.h?rev=248313&r1=248312&r2=248313&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/include/atomic_support.h?rev=248313&r1=248312&r2=248313&view=diff</a><br>
> ==============================================================================<br>
> --- libcxx/trunk/src/include/atomic_support.h (original)<br>
> +++ libcxx/trunk/src/include/atomic_support.h Tue Sep 22 13:55:37 2015<br>
> @@ -103,6 +103,13 @@ void __libcpp_atomic_store(_ValueType* _<br>
>      *__dest = __val;<br>
>  }<br>
><br>
> +template <class _ValueType, class _FromType><br>
> +inline _LIBCPP_INLINE_VISIBILITY<br>
> +void __libcpp_relaxed_store(_ValueType* __dest, _FromType __val)<br>
> +{<br>
> +    *__dest = __val;<br>
> +}<br>
> +<br>
>  template <class _ValueType><br>
>  inline _LIBCPP_INLINE_VISIBILITY<br>
>  _ValueType __libcpp_atomic_load(_ValueType const* __val,<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>