<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-GB link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>Hi all,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Address spaces are not handled in custom semantic checks of atomic Builtins.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>If there are two pointers passed to the Builtin, it doesn't allow the second<o:p></o:p></p><p class=MsoNormal>(non-atomic) one to be qualified with an address space. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>This patch removed this restriction by recording the address space of the<o:p></o:p></p><p class=MsoNormal>passed pointers while checking its type correctness.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Currently, the following code:<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>_Atomic int __attribute__((address_space(1))) *A;<o:p></o:p></p><p class=MsoNormal>int __attribute__((address_space(2))) *B;<o:p></o:p></p><p class=MsoNormal>...<o:p></o:p></p><p class=MsoNormal>... = __c11_atomic_compare_exchange_strong(A, B, 1, memory_order_seq_cst, memory_order_seq_cst);<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>fails to compile with an error: <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>"passing '__attribute__((address_space(2))) int *' to parameter of type 'int *' changes address space of pointer".<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Please, review the attached fix for it!<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Cheers,<o:p></o:p></p><p class=MsoNormal>Anastasia<o:p></o:p></p></div></body></html>