<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 18, 2015 at 8:22 PM, Saleem Abdulrasool via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">compnerd accepted this revision.<br>
compnerd added a reviewer: compnerd.<br>
compnerd added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
Looks fine minus the one thing that needs a quick look at.<br>
<br>
<br>
================<br>
Comment at: include/clang/Driver/Options.td:952<br>
@@ -951,1 +951,3 @@<br>
<span class=""> def fno_pie : Flag<["-"], "fno-pie">, Group<f_Group>;<br>
+def fplugin : Joined<["-"], "fplugin=">, Group<f_Group>, Flags<[DriverOption]>, MetaVarName<"<dsopath>">,<br>
+  HelpText<"Load the named plugin (dynamic shared object)">;<br>
</span>----------------<br>
Don't most options of this type use the _EQ suffix?  Might be nice to follow the convention.</blockquote><div><br></div><div>Please follow the rules listed on lines 106-123 of this file.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D12903" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12903</a><br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>