<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 11, 2015 at 11:54 AM, Adrian Prantl via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Fri Sep 11 13:54:28 2015<br>
New Revision: 247447<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247447&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247447&view=rev</a><br>
Log:<br>
Remove a redundant check from CGDebugInfo::shouldOmitDefinition() (NFC).<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=247447&r1=247446&r2=247447&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp?rev=247447&r1=247446&r2=247447&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Fri Sep 11 13:54:28 2015<br>
@@ -1480,14 +1480,8 @@ static bool shouldOmitDefinition(CodeGen<br>
                                  const RecordDecl *RD,<br>
                                  const LangOptions &LangOpts) {<br>
   // Does the type exist in an imported clang module?<br>
-  if (DebugTypeExtRefs && RD->isFromASTFile()) {<br>
-    if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(RD))<br>
-      if (CTSD->isExplicitInstantiationOrSpecialization())<br>
-        // We may not assume that this type made it into the module.<br>
-        return true;<br>
-    if (RD->getDefinition())<br>
+  if (DebugTypeExtRefs && RD->isFromASTFile() && RD->getDefinition())<br></blockquote><div><br></div><div>Oh - and do we need to check for "getDefinition" here? Since this function is itself (by name/use) already about whether definitions should be omitted? I'm not sure, maybe it still makes sense... </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
       return true;<br>
-  }<br>
<br>
   if (DebugKind > CodeGenOptions::LimitedDebugInfo)<br>
     return false;<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>