<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">+ Argyrios</div><div class=""><br class=""></div><div class="">Hi Angel,</div><div class=""><br class=""></div><div class="">I believe Argyrios is the original author of the code in question, as this looks related to the Objective-C “modernizer” migrator he wrote a while back. This code started life on our internal development branch at Apple related to an Xcode feature we were doing, and I did the work on pushing it back to open source trunk. Argyrios is the best one to answer your technical question here.</div><div class=""><br class=""></div><div class="">Ted</div><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 9, 2015, at 6:05 AM, Angel Garcia <<a href="mailto:angelgarcia@google.com" class="">angelgarcia@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">+cfe-commits</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Sep 8, 2015 at 6:56 PM, Angel Garcia <span dir="ltr" class=""><<a href="mailto:angelgarcia@google.com" target="_blank" class="">angelgarcia@google.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Ted,<div class=""><br class=""></div><div class="">I was working on a clang-tidy check, and today I discovered that it was unable to do several replacements in different arguments of the same macro call. At first, I thought it was a bug, and trying to figure out why this was happening, I found that the replacements were rejected in <i class="">lib/Edit/EditedSource.cpp:46</i>, where there is a comment that says "Trying to write in a macro argument input that has already been written for another argument of the same macro". This comment means that this changes are rejected on purpose.</div><div class=""><br class=""></div><div class="">At the commit history, I saw that you had <a href="http://reviews.llvm.org/rL152141" target="_blank" class="">commited</a> this code (that's why I am asking you). Do you think that there is a way around this? I don't really understand why there is a particular case for the macros here, and understanding it would help me to decide whether I should give up on trying to make this work, or try to find a "better" solution.</div><div class=""><br class=""></div><div class="">Thanks and sorry for the inconvenience,</div><div class="">Angel</div></div>
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>