<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 10, 2015 at 10:13 AM, Adrian Prantl via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Thu Sep 10 12:13:31 2015<br>
New Revision: 247303<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247303&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247303&view=rev</a><br>
Log:<br>
Debug Info: Remove an unnecessary debug type visitor.<br>
Thanks to dblaikie for spotting this.<br>
<br>
Modified:<br>
cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp<br>
cfe/trunk/test/Modules/ModuleDebugInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp?rev=247303&r1=247302&r2=247303&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp?rev=247303&r1=247302&r2=247303&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Thu Sep 10 12:13:31 2015<br>
@@ -70,13 +70,6 @@ class PCHContainerGenerator : public AST<br>
return true;<br>
}<br>
<br>
- bool VisitValueDecl(ValueDecl *D) {<br>
- QualType QualTy = D->getType();<br>
- if (!QualTy.isNull() && CanRepresent(QualTy.getTypePtr()))<br>
- DI.getOrCreateStandaloneType(QualTy, D->getLocation());<br>
- return true;<br>
- }<br>
-<br>
bool VisitObjCInterfaceDecl(ObjCInterfaceDecl *D) {<br>
QualType QualTy(D->getTypeForDecl(), 0);<br>
if (!QualTy.isNull() && CanRepresent(QualTy.getTypePtr()))<br>
<br>
Modified: cfe/trunk/test/Modules/ModuleDebugInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/ModuleDebugInfo.cpp?rev=247303&r1=247302&r2=247303&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/ModuleDebugInfo.cpp?rev=247303&r1=247302&r2=247303&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Modules/ModuleDebugInfo.cpp (original)<br>
+++ cfe/trunk/test/Modules/ModuleDebugInfo.cpp Thu Sep 10 12:13:31 2015<br>
@@ -7,10 +7,12 @@<br>
// RUN: rm -rf %t<br>
// RUN: %clang_cc1 -triple %itanium_abi_triple -x objective-c++ -std=c++11 -g -fmodules -fmodule-format=obj -fimplicit-module-maps -DMODULES -fmodules-cache-path=%t %s -I %S/Inputs -I %t -emit-llvm -o %t.ll -mllvm -debug-only=pchcontainer &>%t-mod.ll<br>
// RUN: cat %t-mod.ll | FileCheck %s<br>
+// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s<br>
<br>
// PCH:<br>
// RUN: %clang_cc1 -triple %itanium_abi_triple -x c++ -std=c++11 -emit-pch -fmodule-format=obj -I %S/Inputs -o %t.pch %S/Inputs/DebugCXX.h -mllvm -debug-only=pchcontainer &>%t-pch.ll<br>
// RUN: cat %t-pch.ll | FileCheck %s<br>
+// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s<br>
<br>
#ifdef MODULES<br>
@import DebugCXX;<br>
@@ -30,12 +32,11 @@<br>
// CHECK: !DICompositeType(tag: DW_TAG_class_type,<br>
// CHECK-SAME: name: "Template<float, DebugCXX::traits<float> >"<br>
// CHECK-SAME: identifier: "_ZTSN8DebugCXX8TemplateIfNS_6traitsIfEEEE")<br>
-// CHECK: !DICompositeType(tag: DW_TAG_class_type,<br>
-// CHECK-SAME: name: "Template<long, DebugCXX::traits<long> >"<br>
-// CHECK-SAME: identifier: "_ZTSN8DebugCXX8TemplateIlNS_6traitsIlEEEE")<br>
// CHECK: !DICompositeType(tag: DW_TAG_class_type, name: "A<void>"<br>
// CHECK-SAME: identifier: "_ZTSN8DebugCXX1AIJvEEE")<br>
// CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "FloatInstatiation"<br>
// no mangled name here yet.<br>
// CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "B",<br>
// no mangled name here yet.<br>
+<br>
+// CHECK-NEG-NOT: "_ZTSN8DebugCXX8TemplateIlNS_6traitsIlEEEE"<br></blockquote><div><br>Rather than using a separate check - maybe do the same sort of thing we do for DWARF testing, CHECK-NOT between each DICompositeType, to ensure we only get the types we intended? (including a CHECK-NOT at the end to ensure there aren't any trailing ones)<br><br>But also: How does the current implementation avoid emitting this type? I thought it visited all the type decls, even those not immediately in the module? (you mentioned that was something that you were planning to address in a future patch) Is that not the case? Is this now sufficient to only emit the decls immediately in this module?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>