<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rjmccall<br>
Date: Tue Sep  8 04:18:30 2015<br>
New Revision: 246991<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246991&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246991&view=rev</a><br>
Log:<br>
When building the alloca for a local variable, set its name<br>
separately from building the instruction so that it's<br>
preserved even in -Asserts builds.<br></blockquote><div><br>Why do we want to preserve this name in particular in -Asserts builds?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Employ C++'s mystical "comment" feature to discourage<br>
breaking this in the future.<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGDecl.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDecl.cpp?rev=246991&r1=246990&r2=246991&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGDecl.cpp?rev=246991&r1=246990&r2=246991&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGDecl.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGDecl.cpp Tue Sep  8 04:18:30 2015<br>
@@ -968,7 +968,11 @@ CodeGenFunction::EmitAutoVarAlloca(const<br>
         allocaAlignment = alignment;<br>
       }<br>
<br>
-      address = CreateTempAlloca(allocaTy, allocaAlignment, D.getName());<br>
+      // Create the alloca.  Note that we set the name separately from<br>
+      // building the instruction so that it's there even in no-asserts<br>
+      // builds.<br>
+      address = CreateTempAlloca(allocaTy, allocaAlignment);<br>
+      address.getPointer()->setName(D.getName());<br>
<br>
       // Emit a lifetime intrinsic if meaningful.  There's no point<br>
       // in doing this if we don't have a valid insertion point (?).<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>