<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Sep 8, 2015, at 8:25 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Tue, Sep 8, 2015 at 2:18 AM, John McCall via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rjmccall<br class="">
Date: Tue Sep 8 04:18:30 2015<br class="">
New Revision: 246991<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246991&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=246991&view=rev</a><br class="">
Log:<br class="">
When building the alloca for a local variable, set its name<br class="">
separately from building the instruction so that it's<br class="">
preserved even in -Asserts builds.<br class=""></blockquote><div class=""><br class="">Why do we want to preserve this name in particular in -Asserts builds?<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>It’s a fairly small runtime cost — no twine appending, only present on a tiny fraction of instructions, unlikely to collide within a single function — that makes reading the IR dramatically easier. That’s still useful to be able to do with a production compiler, both for us and for sophisticated users.</div><div><br class=""></div><div>IIRC, Daniel did the perf work on IR names way back when; he might have other thoughts.</div><div><br class=""></div><div>John.</div></body></html>