<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 7, 2015 at 7:18 AM, Xan López <span dir="ltr"><<a href="mailto:xan@igalia.com" target="_blank">xan@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, Sep 05, 2015 at 12:28:43PM -0700, Saleem Abdulrasool wrote:<br>
> > Ping?<br>
> ><br>
><br>
> Testcase?  Looks fine otherwise.<br>
<br>
</span>Basically check that -lc is present when clang is called in a certain<br>
way I guess? Or something more sophisticated?</blockquote><div><br></div><div>Yeah, that it is present when a DSO or executable is linked.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><br>
Xan<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
><br>
> > > From 8e81d6b095542c0ff1e28cf1f09d675f8afe1a25 Mon Sep 17 00:00:00 2001<br>
> > > From: =?UTF-8?q?Xan=20L=C3=B3pez?= <<a href="mailto:xan@igalia.com">xan@igalia.com</a>><br>
> > > Date: Mon, 17 Aug 2015 16:04:26 +0200<br>
> > > Subject: [PATCH 4/4] [Solaris] Add -lc also when linking shared libraries<br>
> > ><br>
> > > This is actually needed, otherwise libc won't be added at all. For<br>
> > > instance when building libclang.so all the libc symbols won't be<br>
> > > found, with ld warning about libc being an "implicit dependency".<br>
> > > ---<br>
> > >  lib/Driver/Tools.cpp | 2 +-<br>
> > >  1 file changed, 1 insertion(+), 1 deletion(-)<br>
> > ><br>
> > > diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp<br>
> > > index cf01d7b..2034c0f 100644<br>
> > > --- a/lib/Driver/Tools.cpp<br>
> > > +++ b/lib/Driver/Tools.cpp<br>
> > > @@ -6899,9 +6899,9 @@ void solaris::Linker::ConstructJob(Compilation &C,<br>
> > const JobAction &JA,<br>
> > >      if (getToolChain().getDriver().CCCIsCXX())<br>
> > >        getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs);<br>
> > >      CmdArgs.push_back("-lgcc_s");<br>
> > > +    CmdArgs.push_back("-lc");<br>
> > >      if (!Args.hasArg(options::OPT_shared)) {<br>
> > >        CmdArgs.push_back("-lgcc");<br>
> > > -      CmdArgs.push_back("-lc");<br>
> > >        CmdArgs.push_back("-lm");<br>
> > >      }<br>
> > >    }<br>
> > > --<br>
> > > 2.4.3<br>
> > ><br>
> ><br>
> > > _______________________________________________<br>
> > > cfe-commits mailing list<br>
> > > <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> > > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
> ><br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
> ><br>
><br>
><br>
><br>
> --<br>
> Saleem Abdulrasool<br>
> compnerd (at) compnerd (dot) org<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>