<div dir="ltr">On Fri, Sep 4, 2015 at 1:12 AM, Xan López via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Aug 28, 2015 at 07:53:40PM +0200, Xan López via cfe-commits wrote:<br>
> This is actually needed, otherwise libc won't be added at all. For<br>
> instance when building libclang.so all the libc symbols won't be<br>
> found, with ld warning about libc being an "implicit dependency".<br>
><br>
> ((This patch sits on top of a couple of unreviewed patches that make clang actually work on Solaris, see:<br>
><br>
> <a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150810/292800.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150810/292800.html</a><br>
> <a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150817/293971.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150817/293971.html</a><br>
><br>
> It should be trivial to rebase against master if it is reviewed first though)<br>
><br>
> Xan<br>
<br>
</div></div>Ping?<br></blockquote><div><br></div><div>Testcase?  Looks fine otherwise.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> From 8e81d6b095542c0ff1e28cf1f09d675f8afe1a25 Mon Sep 17 00:00:00 2001<br>
> From: =?UTF-8?q?Xan=20L=C3=B3pez?= <<a href="mailto:xan@igalia.com">xan@igalia.com</a>><br>
> Date: Mon, 17 Aug 2015 16:04:26 +0200<br>
> Subject: [PATCH 4/4] [Solaris] Add -lc also when linking shared libraries<br>
<span class="">><br>
> This is actually needed, otherwise libc won't be added at all. For<br>
> instance when building libclang.so all the libc symbols won't be<br>
> found, with ld warning about libc being an "implicit dependency".<br>
</span>> ---<br>
>  lib/Driver/Tools.cpp | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp<br>
> index cf01d7b..2034c0f 100644<br>
> --- a/lib/Driver/Tools.cpp<br>
> +++ b/lib/Driver/Tools.cpp<br>
> @@ -6899,9 +6899,9 @@ void solaris::Linker::ConstructJob(Compilation &C, const JobAction &JA,<br>
>      if (getToolChain().getDriver().CCCIsCXX())<br>
>        getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs);<br>
>      CmdArgs.push_back("-lgcc_s");<br>
> +    CmdArgs.push_back("-lc");<br>
>      if (!Args.hasArg(options::OPT_shared)) {<br>
>        CmdArgs.push_back("-lgcc");<br>
> -      CmdArgs.push_back("-lc");<br>
>        CmdArgs.push_back("-lm");<br>
>      }<br>
>    }<br>
> --<br>
> 2.4.3<br>
><br>
<br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>