<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 24, 2015 at 5:44 PM, Vedant Kumar via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM with a caveat.<br>
<br>
Changing diagnostic messages is scary because it can inadvertently break tools and IDE's. So there is a chance someone might want this reverted in the future. But for now it seems helpful :).<br></blockquote><div><br></div><div>To the best of my knowledge, we have no policy which forbids us from adding/removing/changing diagnostics.  Was this discussed at some point in the past?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
vedant<br>
<div><div class="h5"><br>
On Aug 24, 2015, at 1:19 PM, Nick Lewycky via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
<br>
> On 19 August 2015 at 15:18, Nick Lewycky <<a href="mailto:nlewycky@google.com">nlewycky@google.com</a>> wrote:<br>
> On 10 August 2015 at 19:08, Nick Lewycky <<a href="mailto:nlewycky@google.com">nlewycky@google.com</a>> wrote:<br>
> This simple-minded patch extends the case where we report "no viable conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable conversion from returned value of type 'X' to function return type 'Y'" when used in that context.<br>
><br>
> In lieu of adding tests for this diagnostic explicitly, I've only updated the tests where the patch changes their result.<br>
><br>
> Please review!<br>
><br>
> Ping!<br>
><br>
> Ping!<br>
</div></div>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=nRkKAYlatRp-Wgk-tAtmRg&m=zsNXNManBK37vPs3xRquJLuWu0PUZNNKbjXmDbYrT18&s=36cwmt-VUhgwwq4FvAY4AnJXluk0LRYerkogSqFNuqM&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=nRkKAYlatRp-Wgk-tAtmRg&m=zsNXNManBK37vPs3xRquJLuWu0PUZNNKbjXmDbYrT18&s=36cwmt-VUhgwwq4FvAY4AnJXluk0LRYerkogSqFNuqM&e=</a><br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>