<div dir="ltr">The tests <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/6531/">are passing now</a>. Will now try to add back the piece of test that was removed and see whether it works.<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 20, 2015 at 2:00 AM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">After looking at the code once again, I found an obvious use-after-free bug which could have caused all of this (and for some reason only manifested itself on Darwin). r245524 should fix the issue.<div><div class="h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 20, 2015 at 1:44 AM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">That didn't work either - both tests are still failing.<br>
<div><div><br>
Alexander Kornienko <<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>> writes:<br>
> Something weird happens with options reading. Submitted a possible workaround<br>
> in r245517.<br>
><br>
> On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner <<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>> wrote:<br>
><br>
> Locally, it seems to fail two tests now:<br>
><br>
> Failing Tests (2):<br>
> Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp<br>
> Clang Tools :: clang-tidy/modernize-use-nullptr.cpp<br>
><br>
> I'll poke at it for a minute and see if there's something obvious I can<br>
> do, but running the run line manually just seems to return 127 with no<br>
> output for me (as opposed to the output that's printed correctly under<br>
> lit)<br>
><br>
> Alexander Kornienko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> writes:<br>
> > I've committed the check with minor modifications and without the<br>
> offending<br>
> > test in r245511. Could you verify that it works in your setup?<br>
> ><br>
> > -- Alex<br>
> ><br>
> > On Wed, Aug 19, 2015 at 11:41 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>><br>
> wrote:<br>
> ><br>
> > On Aug 19, 2015, at 2:38 PM, Alexander Kornienko <<br>
> <a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>><br>
> > wrote:<br>
> ><br>
> > The check has been reverted in r245493. Sorry for the breakage,<br>
> I was<br>
> > hoping that this commit fixes it.<br>
> ><br>
> > No problem. Thanks for taking a look.<br>
> ><br>
> > If you think the rest of the code is good and want to land it again<br>
> then<br>
> > thats fine. You can leave out the check below until you are happy<br>
> that<br>
> > its working too. That way you potentially won’t be blocked for too<br>
> long.<br>
> ><br>
> > Thanks,<br>
> > Pete<br>
> ><br>
> > On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper <<br>
> <a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>><br>
> > wrote:<br>
> ><br>
> > Looks like its only a single test thats failing.<br>
> ><br>
> > Would you mind if I remove this piece of the test until we<br>
> can get<br>
> > to the bottom of it?<br>
> ><br>
> > void test_macro_expansion4() {<br>
> > #define MY_NULL NULL<br>
> > int *p = MY_NULL;<br>
> > // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: use<br>
> nullptr<br>
> > [modernize-use-nullptr]<br>
> > // CHECK-FIXES: int *p = nullptr;<br>
> > #undef MY_NULL<br>
> > }<br>
> ><br>
> > Thanks,<br>
> > Pete<br>
> ><br>
> > On Aug 19, 2015, at 1:00 PM, Pete Cooper <<br>
> > <a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>> wrote:<br>
> ><br>
> > Hi Alexander<br>
> ><br>
> > We’re still getting a green dragon failure on the null<br>
> ptr<br>
> > check test. Mind taking a look?<br>
> ><br>
> > <a href="http://lab.llvm.org:8080/green/job/" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/green/job/</a><br>
> > clang-stage1-configure-RA_check/10351/consoleFull#<br>
> > 50560140149ba4694-19c4-4d7e-bec5-911270d8a58c<br>
> ><br>
> > Thanks<br>
> > Pete<br>
> ><br>
> > On Aug 19, 2015, at 10:50 AM, Alexander Kornienko<br>
> via<br>
> > cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> ><br>
> > Author: alexfh<br>
> > Date: Wed Aug 19 12:50:22 2015<br>
> > New Revision: 245471<br>
> ><br>
> > URL: <a href="https://urldefense.proofpoint.com/v2/url?u=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=</a><br>
> > <br>
> http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245471-26view-3Drev<br>
> > &d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=<br>
> > 03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=<br>
> > vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=<br>
> > wuoYp-wW8aBSkIHSX7igi7DHfur7JyIHWwnzHMTYdlg&e=<br>
> > Log:<br>
> > [clang-tidy] Fix a bug in UseNullptrCheck.<br>
> ><br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=</a><br>
> > http-3A__reviews.llvm.org_D12162&d=BQIGaQ&c=<br>
> > eEvniauFctOgLOKGJOplqw&r=<br>
> > 03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=<br>
> > vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=<br>
> > YiXUYCqfOl7durvaPOdifn3l7_G0FJhlE4A_q5Q6xwM&e=<br>
> ><br>
> > Patch by Angel Garcia!<br>
> ><br>
> > Modified:<br>
> > clang-tools-extra/trunk/clang-tidy/modernize/<br>
> > UseNullptrCheck.cpp<br>
> ><br>
> > Modified: clang-tools-extra/trunk/clang-tidy/<br>
> modernize/<br>
> > UseNullptrCheck.cpp<br>
> > URL: <a href="https://urldefense.proofpoint.com/v2/url?u=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=</a><br>
> > <br>
> http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_clang-2Dtidy_modernize_UseNullptrCheck.cpp-3Frev-3D245471-26r1-3D245470-26r2-3D245471-26view-3Ddiff<br>
> > &d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=<br>
> > 03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=<br>
> > vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=<br>
> > 4y-EkuMJJlcYjI15KrZY8VE3eGEhkvg9ScDcHtItY2g&e=<br>
> > ====================================================<br>
> ======<br>
> > ====================<br>
> > --- clang-tools-extra/trunk/clang-tidy/modernize/<br>
> > UseNullptrCheck.cpp (original)<br>
> > +++ clang-tools-extra/trunk/clang-tidy/modernize/<br>
> > UseNullptrCheck.cpp Wed Aug 19 12:50:22 2015<br>
> > @@ -175,10 +175,10 @@ private:<br>
> > class CastSequenceVisitor : public<br>
> RecursiveASTVisitor<br>
> > <CastSequenceVisitor> {<br>
> > public:<br>
> > CastSequenceVisitor(ASTContext &Context,<br>
> > - SmallVector<StringRef, 1><br>
> > UserNullMacros,<br>
> > + ArrayRef<StringRef><br>
> UserNullMacros,<br>
> > ClangTidyCheck &check)<br>
> > : SM(Context.getSourceManager()), Context<br>
> (Context),<br>
> > - UserNullMacros(std::move(UserNullMacros)),<br>
> Check<br>
> > (check),<br>
> > + UserNullMacros(UserNullMacros), Check<br>
> (check),<br>
> > FirstSubExpr(nullptr), PruneSubtree(false)<br>
> {}<br>
> ><br>
> > bool TraverseStmt(Stmt *S) {<br>
> > @@ -435,7 +435,7 @@ private:<br>
> > private:<br>
> > SourceManager &SM;<br>
> > ASTContext &Context;<br>
> > - const SmallVector<StringRef, 1> &UserNullMacros;<br>
> > + ArrayRef<StringRef> UserNullMacros;<br>
> > ClangTidyCheck &Check;<br>
> > Expr *FirstSubExpr;<br>
> > bool PruneSubtree;<br>
> ><br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> > <a href="https://urldefense.proofpoint.com/v2/url?u=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=</a><br>
> > <br>
> http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits<br>
> > &d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=<br>
> > 03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=<br>
> > vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=<br>
> > UUHB6kbqbYNAr9eIu4oMQTKtxnQ37-xusL7D-UY0GR4&e=<br>
> ><br>
> > _______________________________________________<br>
> > cfe-commits mailing list<br>
> > <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div></div></div></div></div></blockquote></div><br>
</div></div>