<div dir="ltr">I've committed the check with minor modifications and without the offending test in r245511. Could you verify that it works in your setup?<div><br></div><div>-- Alex<br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 19, 2015 at 11:41 PM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Aug 19, 2015, at 2:38 PM, Alexander Kornienko <<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>> wrote:</div><br><div><div dir="ltr">The check has been reverted in <span style="font-size:12.8000001907349px">r245493. Sorry for the breakage, I was hoping that this commit fixes it.</span><br></div></div></blockquote></span>No problem. Thanks for taking a look.</div><div><br></div><div>If you think the rest of the code is good and want to land it again then thats fine. You can leave out the check below until you are happy that its working too. That way you potentially won’t be blocked for too long.</div><div><br></div><div>Thanks,</div><div>Pete</div><div><div class="h5"><div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper <span dir="ltr"><<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Looks like its only a single test thats failing.<div><br></div><div>Would you mind if I remove this piece of the test until we can get to the bottom of it?</div><div><br></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div><div>void test_macro_expansion4() {</div></div><div><div>#define MY_NULL NULL</div></div><div><div> int *p = MY_NULL;</div></div><div><div> // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: use nullptr [modernize-use-nullptr]</div></div><div><div> // CHECK-FIXES: int *p = nullptr;</div></div><div><div>#undef MY_NULL</div></div><div><div>}</div></div></blockquote><div><div><br></div><div>Thanks,</div><div>Pete</div><div><div><div><blockquote type="cite"><div>On Aug 19, 2015, at 1:00 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank">peter_cooper@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">Hi Alexander<div><br></div><div>We’re still getting a green dragon failure on the null ptr check test. Mind taking a look?</div><div><br></div><div><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8080_green_job_clang-2Dstage1-2Dconfigure-2DRA-5Fcheck_10351_consoleFull-2350560140149ba4694-2D19c4-2D4d7e-2Dbec5-2D911270d8a58c&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=egkIy3ZyHViev_djzwydHEvkmBTxiHkYi7IViAItTvY&s=Jk2TDC-f1lko8XlDHLjnD9998CpHgKUoBidcEOk2xIc&e=" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10351/consoleFull#50560140149ba4694-19c4-4d7e-bec5-911270d8a58c</a></div><div><br></div><div>Thanks</div><div>Pete<br><div><blockquote type="cite"><div>On Aug 19, 2015, at 10:50 AM, Alexander Kornienko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:</div><br><div>Author: alexfh<br>Date: Wed Aug 19 12:50:22 2015<br>New Revision: 245471<br><br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245471-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=wuoYp-wW8aBSkIHSX7igi7DHfur7JyIHWwnzHMTYdlg&e=" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245471-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=wuoYp-wW8aBSkIHSX7igi7DHfur7JyIHWwnzHMTYdlg&e=</a> <br>Log:<br>[clang-tidy] Fix a bug in UseNullptrCheck.<br><br><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12162&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=YiXUYCqfOl7durvaPOdifn3l7_G0FJhlE4A_q5Q6xwM&e=" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12162&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=YiXUYCqfOl7durvaPOdifn3l7_G0FJhlE4A_q5Q6xwM&e=</a> <br><br>Patch by Angel Garcia!<br><br>Modified:<br> clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br><br>Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br>URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_clang-2Dtidy_modernize_UseNullptrCheck.cpp-3Frev-3D245471-26r1-3D245470-26r2-3D245471-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=4y-EkuMJJlcYjI15KrZY8VE3eGEhkvg9ScDcHtItY2g&e=" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_clang-2Dtidy_modernize_UseNullptrCheck.cpp-3Frev-3D245471-26r1-3D245470-26r2-3D245471-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=4y-EkuMJJlcYjI15KrZY8VE3eGEhkvg9ScDcHtItY2g&e=</a> <br>==============================================================================<br>--- clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp (original)<br>+++ clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp Wed Aug 19 12:50:22 2015<br>@@ -175,10 +175,10 @@ private:<br> class CastSequenceVisitor : public RecursiveASTVisitor<CastSequenceVisitor> {<br> public:<br> CastSequenceVisitor(ASTContext &Context,<br>- SmallVector<StringRef, 1> UserNullMacros,<br>+ ArrayRef<StringRef> UserNullMacros,<br> ClangTidyCheck &check)<br> : SM(Context.getSourceManager()), Context(Context),<br>- UserNullMacros(std::move(UserNullMacros)), Check(check),<br>+ UserNullMacros(UserNullMacros), Check(check),<br> FirstSubExpr(nullptr), PruneSubtree(false) {}<br><br> bool TraverseStmt(Stmt *S) {<br>@@ -435,7 +435,7 @@ private:<br> private:<br> SourceManager &SM;<br> ASTContext &Context;<br>- const SmallVector<StringRef, 1> &UserNullMacros;<br>+ ArrayRef<StringRef> UserNullMacros;<br> ClangTidyCheck &Check;<br> Expr *FirstSubExpr;<br> bool PruneSubtree;<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=UUHB6kbqbYNAr9eIu4oMQTKtxnQ37-xusL7D-UY0GR4&e=" target="_blank">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=UUHB6kbqbYNAr9eIu4oMQTKtxnQ37-xusL7D-UY0GR4&e=</a> <br></div></blockquote></div></div></div></div></blockquote></div></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div><br>
</div></div></div>