<div dir="ltr">Thanks, Benjamin!<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 20, 2015 at 11:47 AM, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Thu Aug 20 04:47:06 2015<br>
New Revision: 245548<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245548&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245548&view=rev</a><br>
Log:<br>
[clang-tidy] Fold the meat of the UseNullPtrCheck into an anonymous namespace.<br>
<br>
While convenient, RecursiveASTVisitor generates a ridiculous amount of dead<br>
template code. Making it not visible from the outside lets the compiler<br>
eliminate some of it, shrinking clang-tidy by ~140k.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp?rev=245548&r1=245547&r2=245548&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp?rev=245548&r1=245547&r2=245548&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp Thu Aug 20 04:47:06 2015<br>
@@ -20,6 +20,7 @@ using namespace llvm;<br>
 namespace clang {<br>
 namespace tidy {<br>
 namespace modernize {<br>
+namespace {<br>
<br>
 const char CastSequence[] = "sequence";<br>
<br>
@@ -438,6 +439,7 @@ private:<br>
   Expr *FirstSubExpr;<br>
   bool PruneSubtree;<br>
 };<br>
+} // namespace<br>
<br>
 UseNullptrCheck::UseNullptrCheck(StringRef Name, ClangTidyContext *Context)<br>
     : ClangTidyCheck(Name, Context),<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br>
</div></div>