<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 19, 2015, at 2:38 PM, Alexander Kornienko <<a href="mailto:alexfh@google.com" class="">alexfh@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">The check has been reverted in <span style="font-size:12.8000001907349px" class="">r245493. Sorry for the breakage, I was hoping that this commit fixes it.</span><br class=""></div></div></blockquote>No problem. Thanks for taking a look.</div><div><br class=""></div><div>If you think the rest of the code is good and want to land it again then thats fine. You can leave out the check below until you are happy that its working too. That way you potentially won’t be blocked for too long.</div><div><br class=""></div><div>Thanks,</div><div>Pete</div><div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">Looks like its only a single test thats failing.<div class=""><br class=""></div><div class="">Would you mind if I remove this piece of the test until we can get to the bottom of it?</div><div class=""><br class=""></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px" class=""><div class=""><div class="">void test_macro_expansion4() {</div></div><div class=""><div class="">#define MY_NULL NULL</div></div><div class=""><div class=""> int *p = MY_NULL;</div></div><div class=""><div class=""> // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: use nullptr [modernize-use-nullptr]</div></div><div class=""><div class=""> // CHECK-FIXES: int *p = nullptr;</div></div><div class=""><div class="">#undef MY_NULL</div></div><div class=""><div class="">}</div></div></blockquote><div class=""><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete</div><div class=""><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 19, 2015, at 1:00 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>> wrote:</div><br class=""><div class=""><div style="word-wrap:break-word" class="">Hi Alexander<div class=""><br class=""></div><div class="">We’re still getting a green dragon failure on the null ptr check test. Mind taking a look?</div><div class=""><br class=""></div><div class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8080_green_job_clang-2Dstage1-2Dconfigure-2DRA-5Fcheck_10351_consoleFull-2350560140149ba4694-2D19c4-2D4d7e-2Dbec5-2D911270d8a58c&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=egkIy3ZyHViev_djzwydHEvkmBTxiHkYi7IViAItTvY&s=Jk2TDC-f1lko8XlDHLjnD9998CpHgKUoBidcEOk2xIc&e=" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10351/consoleFull#50560140149ba4694-19c4-4d7e-bec5-911270d8a58c</a></div><div class=""><br class=""></div><div class="">Thanks</div><div class="">Pete<br class=""><div class=""><blockquote type="cite" class=""><div class="">On Aug 19, 2015, at 10:50 AM, Alexander Kornienko via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class="">Author: alexfh<br class="">Date: Wed Aug 19 12:50:22 2015<br class="">New Revision: 245471<br class=""><br class="">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245471-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=wuoYp-wW8aBSkIHSX7igi7DHfur7JyIHWwnzHMTYdlg&e=" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245471-26view-3Drev&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=wuoYp-wW8aBSkIHSX7igi7DHfur7JyIHWwnzHMTYdlg&e=</a> <br class="">Log:<br class="">[clang-tidy] Fix a bug in UseNullptrCheck.<br class=""><br class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12162&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=YiXUYCqfOl7durvaPOdifn3l7_G0FJhlE4A_q5Q6xwM&e=" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12162&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=YiXUYCqfOl7durvaPOdifn3l7_G0FJhlE4A_q5Q6xwM&e=</a> <br class=""><br class="">Patch by Angel Garcia!<br class=""><br class="">Modified:<br class=""> clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br class=""><br class="">Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp<br class="">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_clang-2Dtidy_modernize_UseNullptrCheck.cpp-3Frev-3D245471-26r1-3D245470-26r2-3D245471-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=4y-EkuMJJlcYjI15KrZY8VE3eGEhkvg9ScDcHtItY2g&e=" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_clang-2Dtools-2Dextra_trunk_clang-2Dtidy_modernize_UseNullptrCheck.cpp-3Frev-3D245471-26r1-3D245470-26r2-3D245471-26view-3Ddiff&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=4y-EkuMJJlcYjI15KrZY8VE3eGEhkvg9ScDcHtItY2g&e=</a> <br class="">==============================================================================<br class="">--- clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp (original)<br class="">+++ clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp Wed Aug 19 12:50:22 2015<br class="">@@ -175,10 +175,10 @@ private:<br class=""> class CastSequenceVisitor : public RecursiveASTVisitor<CastSequenceVisitor> {<br class=""> public:<br class=""> CastSequenceVisitor(ASTContext &Context,<br class="">- SmallVector<StringRef, 1> UserNullMacros,<br class="">+ ArrayRef<StringRef> UserNullMacros,<br class=""> ClangTidyCheck &check)<br class=""> : SM(Context.getSourceManager()), Context(Context),<br class="">- UserNullMacros(std::move(UserNullMacros)), Check(check),<br class="">+ UserNullMacros(UserNullMacros), Check(check),<br class=""> FirstSubExpr(nullptr), PruneSubtree(false) {}<br class=""><br class=""> bool TraverseStmt(Stmt *S) {<br class="">@@ -435,7 +435,7 @@ private:<br class=""> private:<br class=""> SourceManager &SM;<br class=""> ASTContext &Context;<br class="">- const SmallVector<StringRef, 1> &UserNullMacros;<br class="">+ ArrayRef<StringRef> UserNullMacros;<br class=""> ClangTidyCheck &Check;<br class=""> Expr *FirstSubExpr;<br class=""> bool PruneSubtree;<br class=""><br class=""><br class="">_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=UUHB6kbqbYNAr9eIu4oMQTKtxnQ37-xusL7D-UY0GR4&e=" target="_blank" class="">https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQIGaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=vEGzlOUc6IO5ny5JKNkJAUEoiokQ1N60GDcHk0yboKQ&s=UUHB6kbqbYNAr9eIu4oMQTKtxnQ37-xusL7D-UY0GR4&e=</a> <br class=""></div></blockquote></div><br class=""></div></div></div></blockquote></div></div></div></div></div></blockquote></div><br class="">
</div></div>
</div></blockquote></div><br class=""></body></html>