<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br>
Date: Tue Aug 18 11:15:44 2015<br>
New Revision: 245304<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245304&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245304&view=rev</a><br>
Log:<br>
We shouldn't need to pass -fno-strict-aliasing when building clang with clang.<br>
<br>
Summary: The code comments in the Makefile indicate this was put in place to support issues when building clang with GCC. Today clang's strict aliasing works, so we shouldn't pass -fno-strict-aliasing when building with clang.<br>
<br>
Reviewers: bogner, echristo<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D12036" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12036</a><br>
<br>
Modified:<br>
    cfe/trunk/CMakeLists.txt<br>
    cfe/trunk/Makefile<br>
<br>
Modified: cfe/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=245304&r1=245303&r2=245304&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=245304&r1=245303&r2=245304&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/CMakeLists.txt (original)<br>
+++ cfe/trunk/CMakeLists.txt Tue Aug 18 11:15:44 2015<br>
@@ -253,7 +253,10 @@ configure_file(<br>
<br>
 # Add appropriate flags for GCC<br>
 if (LLVM_COMPILER_IS_GCC_COMPATIBLE)<br>
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-common -Woverloaded-virtual -fno-strict-aliasing")<br>
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-common -Woverloaded-virtual")<br>
+  if (NOT "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")<br>
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing")<br>
+  endif ()<br>
<br>
   # Enable -pedantic for Clang even if it's not enabled for LLVM.<br>
   if (NOT LLVM_ENABLE_PEDANTIC)<br>
<br>
Modified: cfe/trunk/Makefile<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/Makefile?rev=245304&r1=245303&r2=245304&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/Makefile?rev=245304&r1=245303&r2=245304&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/Makefile (original)<br>
+++ cfe/trunk/Makefile Tue Aug 18 11:15:44 2015<br>
@@ -67,8 +67,11 @@ endif<br>
 #   <a href="http://gcc.gnu.org/PR41874" rel="noreferrer" target="_blank">http://gcc.gnu.org/PR41874</a><br>
 #   <a href="http://gcc.gnu.org/PR41838" rel="noreferrer" target="_blank">http://gcc.gnu.org/PR41838</a></blockquote><div><br></div><div>These two bugs are marked fixed. Do we still need to pass this for gcc, or can we just not pass it anywhere?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
 #<br>
-# We can revisit this when LLVM/Clang support it.<br>
+# We don't need to do this if the host compiler is clang.<br>
+ifeq ($(CXX_COMPILER), "clang")<br>
 CXX.Flags += -fno-strict-aliasing<br>
+endif<br>
+<br>
<br>
 # Set up Clang's tblgen.<br>
 ifndef CLANG_TBLGEN<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>