<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 18, 2015, at 10:48 AM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: cbieneman<br class="">
Date: Tue Aug 18 11:15:44 2015<br class="">
New Revision: 245304<br class="">
<br class="">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D245304-26view-3Drev&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=pZXJ6Mm9h7WjvnCZ5v-TZmTeQe28RrvsLio4Mxk9Bng&e=" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=245304&view=rev</a><br class="">
Log:<br class="">
We shouldn't need to pass -fno-strict-aliasing when building clang with clang.<br class="">
<br class="">
Summary: The code comments in the Makefile indicate this was put in place to support issues when building clang with GCC. Today clang's strict aliasing works, so we shouldn't pass -fno-strict-aliasing when building with clang.<br class="">
<br class="">
Reviewers: bogner, echristo<br class="">
<br class="">
Subscribers: cfe-commits<br class="">
<br class="">
Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D12036&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=yYuJm6MFFbGQcXnF9gfPqO9pNL3S_oeE1T8lqMHw8QE&e=" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D12036</a><br class="">
<br class="">
Modified:<br class="">
cfe/trunk/CMakeLists.txt<br class="">
cfe/trunk/Makefile<br class="">
<br class="">
Modified: cfe/trunk/CMakeLists.txt<br class="">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_CMakeLists.txt-3Frev-3D245304-26r1-3D245303-26r2-3D245304-26view-3Ddiff&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=jvB3eAtU-2kVQfMqXVVIN-JqUnTb3MFSIOHYufVda-0&e=" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/CMakeLists.txt?rev=245304&r1=245303&r2=245304&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/CMakeLists.txt (original)<br class="">
+++ cfe/trunk/CMakeLists.txt Tue Aug 18 11:15:44 2015<br class="">
@@ -253,7 +253,10 @@ configure_file(<br class="">
<br class="">
# Add appropriate flags for GCC<br class="">
if (LLVM_COMPILER_IS_GCC_COMPATIBLE)<br class="">
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-common -Woverloaded-virtual -fno-strict-aliasing")<br class="">
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-common -Woverloaded-virtual")<br class="">
+ if (NOT "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")<br class="">
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing")<br class="">
+ endif ()<br class="">
<br class="">
# Enable -pedantic for Clang even if it's not enabled for LLVM.<br class="">
if (NOT LLVM_ENABLE_PEDANTIC)<br class="">
<br class="">
Modified: cfe/trunk/Makefile<br class="">
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_Makefile-3Frev-3D245304-26r1-3D245303-26r2-3D245304-26view-3Ddiff&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=Fpa1vrJq9zzQxZ23cLdOC9NWQM-g36KaZJMUwz9IVAs&e=" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/cfe/trunk/Makefile?rev=245304&r1=245303&r2=245304&view=diff</a><br class="">
==============================================================================<br class="">
--- cfe/trunk/Makefile (original)<br class="">
+++ cfe/trunk/Makefile Tue Aug 18 11:15:44 2015<br class="">
@@ -67,8 +67,11 @@ endif<br class="">
# <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__gcc.gnu.org_PR41874&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=Nu2Y9ZUMguIJjVLiXZnaPjrUomLtAwp2eDyO0OGOEmM&e=" rel="noreferrer" target="_blank" class="">http://gcc.gnu.org/PR41874</a><br class="">
# <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__gcc.gnu.org_PR41838&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=ZBt3erleNpDp133S9RChymy1ysd3yshd3B-n3c7SaBc&e=" rel="noreferrer" target="_blank" class="">http://gcc.gnu.org/PR41838</a></blockquote><div class=""><br class=""></div><div class="">These two bugs are marked fixed. Do we still need to pass this for gcc, or can we just not pass it anywhere?</div></div></div></div></div></blockquote><div><br class=""></div><div>I don’t have access to gcc to test removing the flag there. I see no reason not to remove it for gcc, but I haven’t and can’t test it. Someone else will need to test it before committing.</div><div><br class=""></div>-Chris</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
#<br class="">
-# We can revisit this when LLVM/Clang support it.<br class="">
+# We don't need to do this if the host compiler is clang.<br class="">
+ifeq ($(CXX_COMPILER), "clang")<br class="">
CXX.Flags += -fno-strict-aliasing<br class="">
+endif<br class="">
+<br class="">
<br class="">
# Set up Clang's tblgen.<br class="">
ifndef CLANG_TBLGEN<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=Hfcbhu5JC70tzQtVGDgDJg&m=SF3YQCNSDdiCV_cpwz5f3s3opK1bBqN4q00Y432V00E&s=1gOfDQ-p57gRTKBN0patGEqgWXVB62F9EoutQAuqopo&e=" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>