<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Richard, I tried to ping you on the review thread but I'm not sure it<br>
got through. Martell requested this be merged to 3.7. What do you<br>
think?</blockquote><div><br></div><div>LGTM</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: martell<br>
> Date: Fri Aug 14 14:05:56 2015<br>
> New Revision: 245084<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=245084&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=245084&view=rev</a><br>
> Log:<br>
> WindowsX86: long double is x87DoubleExtended on mingw<br>
><br>
>     Summary:<br>
>     long double on x86 mingw is 80bits and is aligned to 16bytes<br>
><br>
>         Fixes:<br>
>     <a href="https://llvm.org/bugs/show_bug.cgi?id=24398" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=24398</a><br>
><br>
>     Reviewers: rnk<br>
><br>
>     Subscribers: cfe-commits<br>
><br>
>     Differential Revision: <a href="http://reviews.llvm.org/D12037" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12037</a><br>
><br>
> Modified:<br>
>     cfe/trunk/lib/Basic/Targets.cpp<br>
><br>
> Modified: cfe/trunk/lib/Basic/Targets.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=245084&r1=245083&r2=245084&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=245084&r1=245083&r2=245084&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Basic/Targets.cpp (original)<br>
> +++ cfe/trunk/lib/Basic/Targets.cpp Fri Aug 14 14:05:56 2015<br>
> @@ -3784,7 +3784,10 @@ namespace {<br>
>  class MinGWX86_32TargetInfo : public WindowsX86_32TargetInfo {<br>
>  public:<br>
>    MinGWX86_32TargetInfo(const llvm::Triple &Triple)<br>
> -      : WindowsX86_32TargetInfo(Triple) {}<br>
> +      : WindowsX86_32TargetInfo(Triple) {<br>
> +    LongDoubleWidth = LongDoubleAlign = 128;<br>
> +    LongDoubleFormat = &llvm::APFloat::x87DoubleExtended;<br>
> +  }<br>
>    void getTargetDefines(const LangOptions &Opts,<br>
>                          MacroBuilder &Builder) const override {<br>
>      WindowsX86_32TargetInfo::getTargetDefines(Opts, Builder);<br>
> @@ -4014,7 +4017,10 @@ public:<br>
>  class MinGWX86_64TargetInfo : public WindowsX86_64TargetInfo {<br>
>  public:<br>
>    MinGWX86_64TargetInfo(const llvm::Triple &Triple)<br>
> -      : WindowsX86_64TargetInfo(Triple) {}<br>
> +      : WindowsX86_64TargetInfo(Triple) {<br>
> +    LongDoubleWidth = LongDoubleAlign = 128;<br>
> +    LongDoubleFormat = &llvm::APFloat::x87DoubleExtended;<br>
> +  }<br>
>    void getTargetDefines(const LangOptions &Opts,<br>
>                          MacroBuilder &Builder) const override {<br>
>      WindowsX86_64TargetInfo::getTargetDefines(Opts, Builder);<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>