<div dir="ltr">Hi there,<div><br></div><div>I will remove both test cases, which rely on the existence of the default blacklist. It's handled by the driver anyway, and the code I changed is in the frontend; at this point, there's no such a thing, as a default blacklist, all of them are explicit.</div><div>Just a sec.</div><div><br></div><div>krasin</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 13, 2015 at 4:09 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Tweaked a test in r244970.<br>Could you split it out if you would like to run it for the default target?<br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div dir="ltr">Thank you, Yaron. Understood.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">There is great variety of OSs, compilers, configs in the bots. You can't get the smae with try bots unless everything is duplicated which is a waste. You test locally, commit, watch the bots here:</div><div dir="ltr"><br></div><div dir="ltr"> <a href="http://lab.llvm.org:8011/grid" target="_blank">http://lab.llvm.org:8011/grid</a><br></div><div dir="ltr"><br></div><div dir="ltr">or wait for buildbot failure e-mails which arrive a bit slower. </div><div dir="ltr">Breaks may happen even if you test locally, so it's critical be around after the commit to to resolve such issues.</div><div dir="ltr"><br></div><div dir="ltr"> <a href="http://llvm.org/docs/DeveloperPolicy.html#quality" target="_blank">http://llvm.org/docs/DeveloperPolicy.html#quality</a><br></div><div><div><div dir="ltr"><br></div><div class="gmail_extra"><div dir="ltr"><br></div><div dir="ltr"><br><div class="gmail_quote">2015-08-13 20:51 GMT+03:00 Ivan Krasin <span dir="ltr"><<a href="mailto:krasin@google.com" target="_blank">krasin@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you, Yaron.<div><br></div><div>Sorry for breaking the build, it obviously passed locally and I didn't think about all the variety of the supported configs. :(</div><div><br></div><div>Does LLVM have try bots, so that I can run the tests with my patch before committing it?</div><span><font color="#888888"><div><br></div><div>krasin</div></font></span></blockquote></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 13 August 2015 at 07:15, Yaron Keren via cfe-commits<br>
<span><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br>
> CHECK-EIGHT is failing bots, see<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c</a><br>
<br>
<br>
</span>That check only works if compiler-rt is built in, and supports the<br>
target. I wouldn't put that in a Clang test.<br>
</blockquote></div><br></div>
</div></div></div></div></div></div></div>
</blockquote></div><br></div></div></div><span class="">
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</span></blockquote></div></div>
</blockquote></div><br></div>