<div dir="ltr">Yep. That works.<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 5, 2015 at 5:40 PM Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>What about this change:</div><div><br></div><div>diff --git a/test/Index/print-mangled-name.cpp b/test/Index/print-mangled-name.cpp<br>index 6dcda70..3d74fe5 100644<br>--- a/test/Index/print-mangled-name.cpp<br>+++ b/test/Index/print-mangled-name.cpp<br>@@ -2,7 +2,7 @@<br> // RUN: c-index-test -write-pch %t_linux.ast -target i686-pc-linux-gnu %s</div></div><div style="word-wrap:break-word"><div><br> // RUN: c-index-test -test-print-mangle %t_linux.ast | FileCheck %s --check-prefix=ITANIUM<br> <br></div></div><div style="word-wrap:break-word"><div>-// RUN: c-index-test -write-pch %t_macho.ast -arch x86_64 -mmacosx-version-min=10.6 %s<br>+// RUN: c-index-test -write-pch %t_macho.ast -target x86_64-apple-darwin %s</div></div><div style="word-wrap:break-word"><div><br> // RUN: c-index-test -test-print-mangle %t_macho.ast | FileCheck %s --check-prefix=MACHO<br> <br></div></div><div style="word-wrap:break-word"><div> // RUN: c-index-test -write-pch %t_msft.ast -target i686-pc-win32 %s<br><br></div></div><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On Aug 5, 2015, at 5:06 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Still broken here locally on my machine after updating:<div><br></div><div><div>FAIL: Clang :: Index/print-mangled-name.cpp (3844 of 22837)</div><div>******************** TEST 'Clang :: Index/print-mangled-name.cpp' FAILED ********************</div><div>Script:</div><div>--</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -write-pch /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_linux.ast -target i686-pc-linux-gnu /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -test-print-mangle /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_linux.ast | /usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/FileCheck /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp --check-prefix=ITANIUM</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -write-pch /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_macho.ast -arch x86_64 -mmacosx-version-min=10.6 /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -test-print-mangle /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_macho.ast | /usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/FileCheck /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp --check-prefix=MACHO</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -write-pch /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_msft.ast -target i686-pc-win32 /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp</div><div>/usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-test -test-print-mangle /usr/local/google/home/echristo/builds/build-llvm/tools/clang/test/Index/Output/print-mangled-name.cpp.tmp_msft.ast | /usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/FileCheck /usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp --check-prefix=MICROSOFT</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stderr):</div><div>--</div><div>/usr/local/google/home/echristo/sources/llvm/tools/clang/test/Index/print-mangled-name.cpp:13:11: error: expected string not found in input</div><div>// MACHO: mangled=__Z3fooii</div><div> ^</div><div><stdin>:1:1: note: scanning from here</div><div>macro definition=__llvm__ [mangled=]</div><div>^</div><div><stdin>:1:28: note: possible intended match here</div><div>macro definition=__llvm__ [mangled=]</div><div> ^</div><div><br></div><div>--</div></div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Aug 5, 2015 at 4:11 PM Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com" target="_blank">akyrtzi@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I tentatively made a change to one of the tests and it looks like it worked, so I’ll make the same change to the rest.<br>
<br>
> On Aug 5, 2015, at 3:10 PM, Renato Golin <<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>> wrote:<br>
><br>
> On 5 August 2015 at 18:23, Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com" target="_blank">akyrtzi@gmail.com</a>> wrote:<br>
>> Author: akirtzidis<br>
>> Date: Wed Aug 5 12:23:59 2015<br>
>> New Revision: 244066<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=244066&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=244066&view=rev</a><br>
>> Log:<br>
>> [test/Index] Update libclang tests to use libclang for creating PCH files.<br>
><br>
> Hi,<br>
><br>
> This also broke our bots:<br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/6914" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/6914</a><br>
><br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1882" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/1882</a><br>
><br>
> and 244076 didn't fix it.<br>
><br>
> cheers,<br>
> --renato<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></blockquote></div><br></div></blockquote></div>