<div dir="rtl"><div dir="ltr">Did you mean <span style="font-size:12.8000001907349px">TempParamLists </span>never had more than four members?</div><div dir="ltr">Anyhow, set_size should have asserted if its input is more than the capacity.<br></div><div dir="ltr"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-08-04 17:46 GMT+03:00 Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Tue Aug  4 09:46:06 2015<br>
New Revision: 243987<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D243987-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=V7AWWPzNCDqRdj83JjgW8MLMKLuChssTXhp7ZTcb3b8&s=y8Lg6pEBlKSkFtaBe5BVMm4oXNxjvV6iFxmlznG_xfs&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=243987&view=rev</a><br>
Log:<br>
[Sema] Allocate SmallVector to the right size.<br>
<br>
SmallVector::set_size does not reallocate the vector. Sadly I have no<br>
idea how to test this. The vector never has more than one member in all<br>
of the regression tests.<br>
<br>
Found by inspection.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Sema_SemaTemplateInstantiateDecl.cpp-3Frev-3D243987-26r1-3D243986-26r2-3D243987-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=V7AWWPzNCDqRdj83JjgW8MLMKLuChssTXhp7ZTcb3b8&s=9C7-iBV0n-5Wug1dE94Mi8BuJXLkxKAzUhfqh9gs3iw&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp?rev=243987&r1=243986&r2=243987&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Tue Aug  4 09:46:06 2015<br>
@@ -1657,7 +1657,7 @@ TemplateDeclInstantiator::VisitCXXMethod<br>
   SmallVector<TemplateParameterList *, 4> TempParamLists;<br>
   unsigned NumTempParamLists = 0;<br>
   if (isFriend && (NumTempParamLists = D->getNumTemplateParameterLists())) {<br>
-    TempParamLists.set_size(NumTempParamLists);<br>
+    TempParamLists.resize(NumTempParamLists);<br>
     for (unsigned I = 0; I != NumTempParamLists; ++I) {<br>
       TemplateParameterList *TempParams = D->getTemplateParameterList(I);<br>
       TemplateParameterList *InstParams = SubstTemplateParams(TempParams);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>